Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test example "afd_private_link_service_to_LB" in module "avm-res-cdn-profile" fail #37

Closed
zhangjiale-64 opened this issue Jun 18, 2024 · 10 comments
Assignees
Labels
question Further information is requested Type: Question/Feedback 🙋 Further information is requested or just some feedback

Comments

@zhangjiale-64
Copy link

Describe the issue:

Test the example avm-res-cdn-profile_example_afd_private_link_service_to_LB, there is an error occurs when we open the created resource in azure portal. The subnet/frontend subnet creation fails, because it attempt to enable network policy for the Private Link service on the subnet.
The error as follow:

image

Repro Steps:

  1. Clone a terraform template, such as todo-python-mongo-terraform.
  2. Replace the content of the sample afd_private_link_service_to_LB into the main.tf file of terraform, and comment out the content of the output.tf file in terraform.
  3. Login in with command: az login, azd auth login .
  4. Run azd provision.
  5. Open the created resources in azure portal.

Module Version : 0.1.0

Expected behavior:
All resources can be created successfully, there is no error in azure portal.

@didayal-msft , @Poven795909 and @jongio for notification.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jun 18, 2024
@didayal-msft didayal-msft self-assigned this Jun 18, 2024
@didayal-msft
Copy link
Contributor

Thanks for submitting the issue @zhangjiale-64
I wanted to confirm if the below setting or any other setting has been changed in the configuration?

image

Please feel free to connect internally

@didayal-msft didayal-msft added the Type: Question/Feedback 🙋 Further information is requested or just some feedback label Jun 21, 2024
@zhangjiale-64
Copy link
Author

Thanks for submitting the issue @zhangjiale-64 I wanted to confirm if the below setting or any other setting has been changed in the configuration?

image

Please feel free to connect internally

The settings in the configuration have not changed.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Jul 1, 2024
@Poven795909
Copy link
Collaborator

@zhangjiale-64 I will test at my end and will reach out to you offline for sync on this.

@Poven795909 Poven795909 removed the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Jul 1, 2024
@Poven795909
Copy link
Collaborator

From the screenshot shared, it looks like the error is while applying NSG rules to the subnet. The example code doesnt apply any NSG rules. Looks like the issue due to some organizational policies applied at the subscription level automatically when new subnets are created. The issue is not reproducible at our end with the default configuration.

@v-xuto
Copy link
Member

v-xuto commented Jul 4, 2024

From the screenshot shared, it looks like the error is while applying NSG rules to the subnet. The example code doesnt apply any NSG rules. Looks like the issue due to some organizational policies applied at the subscription level automatically when new subnets are created. The issue is not reproducible at our end with the default configuration.

@jongio Any ideas?

@jongio
Copy link
Member

jongio commented Jul 5, 2024

I'm asking...

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Jul 10, 2024
@didayal-msft didayal-msft added question Further information is requested and removed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Jul 11, 2024
@Poven795909
Copy link
Collaborator

@jongio greetings! were you able to identify the policy impacting the deployment ? We discussed with the AVM core team and have agreed that this issue is related to a subscription policy and not related to the module. If this policy is related to the Azure landing zone , do let us know and we will reach out to the ALZ team for review.

@jongio
Copy link
Member

jongio commented Jul 16, 2024

I did ask around, but we aren't able to determine the cause of this based on the data we have. Yes, any help would be appreciated.

@Poven795909
Copy link
Collaborator

Opened an internal group chat to discuss further. We need access to the Azure SDK Developer Playground subscription to review the policies.

@Poven795909
Copy link
Collaborator

As discussed internally since the failure the is due to NSGs getting deployed through a DINE policy, this is not a module issue. As per terraforms official article for azurerm_subnet , NSGs are not supported for Private link services https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/subnet . Please work internally to get necessary exceptions to the resource groups on these policies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested Type: Question/Feedback 🙋 Further information is requested or just some feedback
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

5 participants