Support portalocker >=2

[dhirschfeld]

The current constraints restrict portalocker to <2:

microsoft-authentication-extensions-for-python/setup.py

Lines 25 to 26 in a0cfe93

	"portalocker~=1.6;platform_system=='Windows'",
	"portalocker~=1.0;platform_system!='Windows'",

IIUC the major version bump was just to remove py2 support so this library should be compatible with portalocker>=1.6

[dhirschfeld]

xref: https://portalocker.readthedocs.io/en/latest/#python-2

[rayluo]

Thanks, Dave, for bringing this to our attention.

Hi Rick (@wolph), would you please confirm whether Portalocker 2.x contains breaking change in its API when comparing to 1.x? The 2.0.0 release log mentioned the removal of Python 2 support. We wonder whether our usage of Portalocker 1.x API would continue to work with Portalocker 2.x, when running on Python 3.5+.

[wolph]

Hi Ray,

The major differences between Portalocker 2.x and 1.x are currently:

1. Full type hinting support
2. Related to the type hinting, there is now a LockFlags enum that can be used: https://portalocker.readthedocs.io/en/latest/portalocker.constants.html?highlight=lockflags#portalocker.constants.LockFlags
3. Support for locks across multiple machines using Redis

For all intents and purposes all Portalocker 1.x code still works on Portalocker 2.x and will continue to do so.

Portalocker 1.x (and Python 2 support) is considered end-of-life but there are no known issues currently. And to maintain both forwards and backwards compatibility I could even backport the LockFlags if desired.

Long story short: yes, you can safely upgrade :)