Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow portalocker 2 on Python 3.5+ #97

Merged
merged 1 commit into from Aug 30, 2021
Merged

Allow portalocker 2 on Python 3.5+ #97

merged 1 commit into from Aug 30, 2021

Conversation

rayluo
Copy link
Contributor

@rayluo rayluo commented Aug 28, 2021

Thanks @dhirschfeld for bringing #94 to our attention. It turns out, our attempt in #95 was not quite there yet, so my offline trial-and-error led me to this PR. It should work, and it will close #94 and close #95.

P.S.: After merging this PR, the change will not immediately go live, but it will be included in our next release.

@dhirschfeld
Copy link

Thanks for following through & figuring it out @rayluo! ❤️

@rayluo rayluo merged commit 26240cb into dev Aug 30, 2021
@rayluo rayluo deleted the allow-portalocker-2 branch August 30, 2021 16:14
@dhirschfeld
Copy link

It looks like this didn't make it into the 0.3.0 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support portalocker >=2
2 participants