Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Integrate DiscoverAccounts API from MSALRuntime into new broker #3458

Closed
7 tasks done
Tracked by #3375
gladjohn opened this issue Jul 7, 2022 · 3 comments · Fixed by #3602
Closed
7 tasks done
Tracked by #3375

[Feature Request] Integrate DiscoverAccounts API from MSALRuntime into new broker #3458

gladjohn opened this issue Jul 7, 2022 · 3 comments · Fixed by #3602
Assignees
Milestone

Comments

@gladjohn
Copy link
Contributor

gladjohn commented Jul 7, 2022

Is your feature request related to a problem? Please describe.
Integrate DiscoverAccounts API from MSALRuntime into new broker. Interop version starting 0.10.0 will have account discovery functionality

  • Test Native Interop 0.12.0
  • publish Native Interop 0.12.0 to NuGet
  • Include Native Interop 0.12.0 into MSAL Broker
  • Integrate the new discoverAccounts functionally into MSAL Broker
  • Manual testing with Dev Apps
  • Validate other accounts scenarios
  • Add integration tests

NOTE : We may need to bump the Interop version before publishing to NuGet

Describe the solution you'd like
Expose Account Discovery in the new broker implementation

Describe alternatives you've considered
n/a

Additional context
Add any other context or screenshots about the feature request here.

@gladjohn gladjohn self-assigned this Jul 21, 2022
@gladjohn gladjohn added this to the 4.46.0 milestone Jul 21, 2022
@pmaytak pmaytak modified the milestones: 4.46.0, 4.47.0 Aug 3, 2022
@gladjohn
Copy link
Contributor Author

Native Interop 0.10.0 Discover Accounts were missing Environment and UserName properties. On 8/11/2022 MSAL Runtime team released the Native Interop 0.11.2 which has these properties, moving this back to in-progress and will start working on this.

@gladjohn
Copy link
Contributor Author

tested and published Native Interop 0.12.0 to NuGet. Included in Broker. Found one bug where the calls gets throttled while doing getAccounts, working on identifying the issue.

@gladjohn gladjohn modified the milestones: 4.47.0, 4.48.0 Sep 17, 2022
@pmaytak pmaytak removed this from the 4.48.0 milestone Nov 2, 2022
@bgavrilMS
Copy link
Member

No longer blocked, the throttling issue has been fixed in MSAL C++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants