Pass account to Auth result #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Mar 2, 2022
src/client/Microsoft.Identity.Client/Internal/Requests/Silent/CacheSilentStrategy.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Mar 2, 2022
src/client/Microsoft.Identity.Client/Internal/Requests/Silent/CacheSilentStrategy.cs
Show resolved
Hide resolved
SameerK-MSFT
suggested changes
Mar 4, 2022
src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Mar 7, 2022
src/client/Microsoft.Identity.Client/Internal/Requests/Silent/CacheSilentStrategy.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Mar 7, 2022
src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
requested changes
Mar 7, 2022
There was a problem hiding this comment.
- No Account for ADFS / B2C shows that we are missing some tests, or some assertion on existing tests
- We now access the CacheManager 3 times - once for Id token, once for tenant profiles and once for account. This is not needed - a single method can do them all.
The tests do not fail since the account object was used only to populate tenant profiles and wam id. Updating the code to use the account passed. |
bgavrilMS
reviewed
Mar 8, 2022
bgavrilMS
reviewed
Mar 8, 2022
| @@ -26,7 +26,7 @@ internal interface ICacheSessionManager | |||
|
|
|||
| Task<IEnumerable<IAccount>> GetAccountsAsync(); | |||
| Task<IDictionary<string, TenantProfile>> GetTenantProfilesAsync(string homeAccountId); | |||
|
|
|||
| Task<Account> GetAccountAssociatedWithAccessTokenAsync(MsalAccessTokenCacheItem msalAccessTokenCacheItem); | |||
There was a problem hiding this comment.
Can we delete GetIdTokenCacheItemAsync and GetTenantProfilesAsync from here and make them private methods in TokenCache class?
There was a problem hiding this comment.
Deleting GetTenantProfilesAsync making it private in TokenCache. Leaving GetIdTokenCacheItemAsync since I did not combine it with tenant profiles as mentioned in #3199 (comment)
bgavrilMS
approved these changes
Mar 8, 2022
pmaytak
approved these changes
Mar 14, 2022
|
|
||
| // Assert | ||
| AssertWamIds(response.Account as Account, 1, "wamId2"); | ||
| Assert.AreEqual(tenant2, response.TenantId); |
There was a problem hiding this comment.
Assert tenant profiles for second account too?
There was a problem hiding this comment.
The second account will only have 1 tenant profile since only 1 id token is present for the home account id. That is why it is not verified for multiple tenant profiles. This is same behavior as existing tests on the cache for tenant profiles.
SameerK-MSFT
approved these changes
Mar 17, 2022
Csaba8472
added a commit
to Csaba8472/microsoft-authentication-library-for-dotnet
that referenced
this pull request
Apr 24, 2022
…library-for-dotnet * 'master' of github.com:AzureAD/microsoft-authentication-library-for-dotnet: (39 commits) OBO for SP with RT support (AzureAD#3266) (AzureAD#3280) Update some projects to net48 (AzureAD#3269) Bump Source Link version (tool change) (AzureAD#3275) Update changelog.txt (AzureAD#3282) Default to WebView1 instead of WebView2 when using AAD or ADFS authorities (AzureAD#3276) Revert "OBO for SP with RT support (AzureAD#3266)" OBO for SP with RT support (AzureAD#3266) Add perf tests for Acquire Token calls with serialization cache and Builders (AzureAD#3250) Minor fix to SuggestedCacheKey comment and update NuGet icon in Readme. (AzureAD#3268) MSAL changelog 4.43.0 (AzureAD#3263) Bogavril/3251 (AzureAD#3255) Fix for AzureAD#3248 - use the correct plugin to sing out (AzureAD#3253) Performance project improvements (AzureAD#3064) Reuse lists in token cache filtering logic. (AzureAD#3233) Update andorid install script to use andorid 30 (AzureAD#3243) Fix for UWP packaging (AzureAD#3239) Pass account to Auth result (AzureAD#3199) App ported to Lab4 (AzureAD#3229) Trwalke/ruleset updates (AzureAD#3189) Conditional Access for Android (AzureAD#3210) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
#3121
Changes proposed in this request
Pass account to auth result
Testing
Added unit tests
Performance impact