Bogavril/3251 #3255
Merged
Bogavril/3251 #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
commented
Mar 30, 2022
| break; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
whitespace was wrong here, probably because the file was worked on from Linux some time back. Only this and another block has changes.
bgavrilMS
commented
Mar 30, 2022
| private string[] GetOpenToolsLinux(bool isBrokerConfigured) | ||
| { | ||
| if (isBrokerConfigured) | ||
| { | ||
| return new[] { "microsoft-edge", "xdg-open", "gnome-open", "kfmclient" }; | ||
| return new[] { "microsoft-edge", "xdg-open", "gnome-open", "kfmclient", "wslview" }; |
There was a problem hiding this comment.
Added wslview tool here.
trwalke
reviewed
Mar 30, 2022
| foreach (string openTool in GetOpenToolsLinux(isBrokerConfigured)) | ||
| { | ||
| if (TryGetExecutablePath(openTool, out string openToolPath)) | ||
| { | ||
| psi = OpenLinuxBrowser(openToolPath, url); | ||
|
|
||
| OpenLinuxBrowser(openToolPath, url); |
There was a problem hiding this comment.
So if this fails it will throw an exception of some kind? does the boolean value returned here no longer matter?
There was a problem hiding this comment.
We were simply not using this at all.
trwalke
approved these changes
Mar 30, 2022
pmaytak
approved these changes
Mar 30, 2022
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePlatformProxy.cs
Outdated
Show resolved
Hide resolved
…PlatformProxy.cs Co-authored-by: Peter M <34331512+pmaytak@users.noreply.github.com>
Csaba8472
added a commit
to Csaba8472/microsoft-authentication-library-for-dotnet
that referenced
this pull request
Apr 24, 2022
…library-for-dotnet * 'master' of github.com:AzureAD/microsoft-authentication-library-for-dotnet: (39 commits) OBO for SP with RT support (AzureAD#3266) (AzureAD#3280) Update some projects to net48 (AzureAD#3269) Bump Source Link version (tool change) (AzureAD#3275) Update changelog.txt (AzureAD#3282) Default to WebView1 instead of WebView2 when using AAD or ADFS authorities (AzureAD#3276) Revert "OBO for SP with RT support (AzureAD#3266)" OBO for SP with RT support (AzureAD#3266) Add perf tests for Acquire Token calls with serialization cache and Builders (AzureAD#3250) Minor fix to SuggestedCacheKey comment and update NuGet icon in Readme. (AzureAD#3268) MSAL changelog 4.43.0 (AzureAD#3263) Bogavril/3251 (AzureAD#3255) Fix for AzureAD#3248 - use the correct plugin to sing out (AzureAD#3253) Performance project improvements (AzureAD#3064) Reuse lists in token cache filtering logic. (AzureAD#3233) Update andorid install script to use andorid 30 (AzureAD#3243) Fix for UWP packaging (AzureAD#3239) Pass account to Auth result (AzureAD#3199) App ported to Lab4 (AzureAD#3229) Trwalke/ruleset updates (AzureAD#3189) Conditional Access for Android (AzureAD#3210) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3251
Add wslview which works on WSL
Manually tested.