Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some projects to net48 #3269

Merged
merged 4 commits into from
Apr 18, 2022
Merged

Update some projects to net48 #3269

merged 4 commits into from
Apr 18, 2022

Conversation

bgavrilMS
Copy link
Member

Test projects only.

trwalke
trwalke approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@trwalke trwalke left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some incompatibility issues with the projects causing the build to fail but looks good otherwise.

pmaytak
pmaytak approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Travis' comments.

@bgavrilMS bgavrilMS merged commit 340ffef into master Apr 18, 2022
@bgavrilMS bgavrilMS deleted the bogavril/net4 branch April 18, 2022 08:43
Csaba8472 added a commit to Csaba8472/microsoft-authentication-library-for-dotnet that referenced this pull request Apr 24, 2022
@Csaba8472
Merge branch 'master' of github.com:AzureAD/microsoft-authentication-…
0004f65 
…library-for-dotnet

* 'master' of github.com:AzureAD/microsoft-authentication-library-for-dotnet: (39 commits)
  OBO for SP with RT support (AzureAD#3266) (AzureAD#3280)
  Update some projects to net48 (AzureAD#3269)
  Bump Source Link version (tool change) (AzureAD#3275)
  Update changelog.txt (AzureAD#3282)
  Default to WebView1 instead of WebView2 when using AAD or ADFS authorities (AzureAD#3276)
  Revert "OBO for SP with RT support (AzureAD#3266)"
  OBO for SP with RT support (AzureAD#3266)
  Add perf tests for Acquire Token calls with serialization cache and Builders (AzureAD#3250)
  Minor fix to SuggestedCacheKey comment and update NuGet icon in Readme. (AzureAD#3268)
  MSAL changelog 4.43.0 (AzureAD#3263)
  Bogavril/3251 (AzureAD#3255)
  Fix for AzureAD#3248 - use the correct plugin to sing out (AzureAD#3253)
  Performance project improvements (AzureAD#3064)
  Reuse lists in token cache filtering logic. (AzureAD#3233)
  Update andorid install script to use andorid 30 (AzureAD#3243)
  Fix for UWP packaging (AzureAD#3239)
  Pass account to Auth result (AzureAD#3199)
  App ported to Lab4 (AzureAD#3229)
  Trwalke/ruleset updates (AzureAD#3189)
  Conditional Access for Android (AzureAD#3210)
  ...
pmaytak pushed a commit that referenced this pull request May 12, 2022
@bgavrilMS @pmaytak
Update some projects to net48 (#3269)
b152494 
* Update some projects to net48

* more

* More

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trwalke trwalke trwalke approved these changes

@pmaytak pmaytak pmaytak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgavrilMS @trwalke @pmaytak