Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msal-common] Device Code Timeout documentation and sample update #3031

Merged
merged 3 commits into from
Feb 17, 2021
Merged

[msal-common] Device Code Timeout documentation and sample update #3031

merged 3 commits into from
Feb 17, 2021

Conversation

hectormmg
Copy link
Member

This PR:

@hectormmg
Add clarification of time unit to Device code timeout configuration a…
0d2b826 
…nd increase the default timeout in the Device code samples to 20s
@github-actions github-actions bot added msal-common Related to msal-common package samples Related to the samples apps for the library. labels Feb 16, 2021
@hectormmg hectormmg changed the title [msal-node] Device Code Timeout documentation and sample update [msal-common] Device Code Timeout documentation and sample update Feb 16, 2021
@coveralls
Copy link

coveralls commented Feb 16, 2021 •
edited
Loading

Coverage Status

Coverage increased (+3.8%) to 86.528% when pulling c4e29ca on node-timeout-update into c9da47e on dev.

@sameerag
Copy link
Member

Can we merge this before the node release? Tagged the milestone.

@sameerag sameerag added this to the @azure/msal-node@1.0.0 milestone Feb 17, 2021
@sameerag sameerag merged commit 6ce0f54 into dev Feb 17, 2021
@sameerag sameerag deleted the node-timeout-update branch February 17, 2021 23:17
This was referenced Feb 18, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@samuelkubai samuelkubai samuelkubai approved these changes

@sameerag sameerag sameerag approved these changes

@pkanher617 pkanher617 Awaiting requested review from pkanher617

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

Assignees
No one assigned
Labels
msal-common Related to msal-common package samples Related to the samples apps for the library.
Projects
None yet
Milestone
@azure/msal-node@1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hectormmg @coveralls @sameerag @jasonnutter @samuelkubai