Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the msal-node device code sample, increase the timeout value from 5 to prevent the login from timing out by default #3017

Closed
2 of 13 tasks
waldekmastykarz opened this issue Feb 12, 2021 · 2 comments
Closed
2 of 13 tasks

In the msal-node device code sample, increase the timeout value from 5 to prevent the login from timing out by default #3017

waldekmastykarz opened this issue Feb 12, 2021 · 2 comments
Assignees
@hectormmg
Labels
documentation Related to documentation. question Customer is asking for a clarification, use case or information.

Comments

@waldekmastykarz
Copy link

Library

  • msal@1.x.x or @azure/msal@1.x.x
  • @azure/msal-browser@2.x.x
  • @azure/msal-node@1.x.x
  • @azure/msal-react@1.x.x
  • @azure/msal-angular@0.x.x
  • @azure/msal-angular@1.x.x
  • @azure/msal-angular@2.x.x
  • @azure/msal-angularjs@1.x.x

Documentation location

  • docs.microsoft.com
  • MSAL.js Github Wiki
  • README file
  • Other (code samples)
  • Documentation does not exist

Description

In the msal-node device code auth sample, increase the timeout value from 5 to something else or consider removing it altogether. With timeout set to 5, the login times out every time while you're going navigating to the device login page and pasting the device code.

Additionally, it would be good to specify why this value is needed as the device code response sent initially from AAD already has a timeout of 900 specified. Is the timeout in the deviceCodeRequest meant to override it? If so, what's the purpose? It would be helpful to clarify this.
@waldekmastykarz waldekmastykarz added documentation Related to documentation. question Customer is asking for a clarification, use case or information. labels Feb 12, 2021
@hectormmg hectormmg self-assigned this Feb 12, 2021
@hectormmg
Copy link
Member

Hi @waldekmastykarz thanks for the feedback! We're in the process of polishing our samples and should have things like this updated soon. Some of these details are defaults that we use for testing purposes that we need to change for the usage samples.

@hectormmg hectormmg mentioned this issue Feb 16, 2021
Merged
@hectormmg
Copy link
Member

Closing since this was addressed in #3031.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hectormmg hectormmg

Labels
documentation Related to documentation. question Customer is asking for a clarification, use case or information.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hectormmg @waldekmastykarz