Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Rate adjustment based on Fine Tune #24

Closed
ferro4prez opened this issue Feb 7, 2023 · 1 comment · Fixed by #26
Closed

Sample Rate adjustment based on Fine Tune #24

ferro4prez opened this issue Feb 7, 2023 · 1 comment · Fixed by #26
Labels
enhancement New feature or request
Milestone

Comments

@ferro4prez
Copy link

The current implementation doesn't take into account the Fine Tune setting in MOD files, and so samples are extracted in the wrong/unintended octave.

@B0ney B0ney added the enhancement New feature or request label Feb 7, 2023
@B0ney
Copy link
Owner

B0ney commented Feb 9, 2023

Here's a nightly link with the sample rate adjustment: https://nightly.link/B0ney/xmodits/actions/runs/4127816315

I think, for the most part, you'll hardly notice any difference. Even with the fine tune adjustment, the frequency will most likely be 8363Hz.

It is worth noting that higher pitched instruments (hi-hats, cymbals, snares, etc) tend to sound a lot lower pitched. This was intentionally done by the sampler to get around the limitations of the hardware at the time. Doing this also allows the sample to be played at a much wider range without losing quality.

@B0ney B0ney mentioned this issue Apr 6, 2023
@B0ney B0ney added this to the 0.10.0 milestone Apr 6, 2023
@B0ney B0ney closed this as completed in #26 May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants