Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvesting ui and tests #9

Merged
merged 6 commits into from
Feb 8, 2018
Merged

Harvesting ui and tests #9

merged 6 commits into from
Feb 8, 2018

Conversation

sandrarum
Copy link
Member

Ui improvements, tests still missing

@coveralls
Copy link

coveralls commented Feb 8, 2018

Pull Request Test Coverage Report for Build 94

  • 42 of 156 (26.92%) changed or added relevant lines in 12 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 55.022%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pkan/dcatapde/config/views.py 0 1 0.0%
src/pkan/dcatapde/content/harvester_field_config.py 0 1 0.0%
src/pkan/dcatapde/browser/add_views/field_config.py 2 3 66.67%
src/pkan/dcatapde/content/harvester.py 3 4 75.0%
src/pkan/dcatapde/browser/edit_views/field_config.py 2 3 66.67%
src/pkan/dcatapde/content/fielddefaultfactory.py 3 4 75.0%
src/pkan/dcatapde/api/harvester.py 0 2 0.0%
src/pkan/dcatapde/harvesting/source_type/data.py 0 7 0.0%
src/pkan/dcatapde/browser/content_views/harvester.py 11 43 25.58%
src/pkan/dcatapde/api/harvester_field_config.py 19 86 22.09%
Files with Coverage Reduction New Missed Lines %
src/pkan/dcatapde/harvesting/source_type/data.py 1 15.63%
src/pkan/dcatapde/api/harvester.py 8 38.33%
Totals Coverage Status
Change from base Build 91: -0.4%
Covered Lines: 1890
Relevant Lines: 3435

💛 - Coveralls

@sandrarum sandrarum merged commit 0ab0d32 into master Feb 8, 2018
@thomasmassmann thomasmassmann deleted the harvesting_ui_and_tests branch February 8, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants