Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to force writing outputs into existing output directory #29

Closed
jpalmer37 opened this issue Jul 2, 2024 · 2 comments
Closed

Comments

@jpalmer37
Copy link

Currently, fluviewer will fail if you give it the command line parameter --outdir . because it already exists. This was implemented to prevent overwrites of existing result folders.

Since the overwrite check is a safe design choice, I don't necessarily want to remove it. I am considering whether we could solely skip an overwrite check if outdir is the present working dir (.) and check any other outputs like normal. Open to suggestions.

@dfornika
Copy link
Member

dfornika commented Jul 2, 2024

How about this? We add a --force flag that allows the user to specify that they want to proceed with analysis even if the outdir already exists.

@dfornika
Copy link
Member

dfornika commented Jul 2, 2024

Fixed in #30

@dfornika dfornika closed this as completed Jul 2, 2024
@dfornika dfornika changed the title Allow output directory to be PWD Allow user to force writing outputs into existing output directory Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants