Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8. Events content page #143

Closed
murphybarb opened this issue Aug 10, 2018 · 5 comments
Closed

8. Events content page #143

murphybarb opened this issue Aug 10, 2018 · 5 comments

Comments

@murphybarb
Copy link

murphybarb commented Aug 10, 2018

No description provided.

@murphybarb
Copy link
Author

murphybarb commented Aug 10, 2018

8. Events content page

Attached files:

  • design mockup of the 8. Events content page, .jpg format (desktop and mobile)
  • ‘marked up’ copy of above template – indicates specific design details (to be added)
  • "Header Footer links BCcampus.ca.pdf" – indicates the location of links in template header and footer

Reference information in the NextCloud project folder

  • List of all templates and menu treatment - file name "templates_sitemap BCcampus.ca.pdf"
  • PDF containing 'markup' copies of all templates and menu treatments – file name "BCcampus.ca template markup.pdf"
  • PDF containing style information for the entire site - file name "BCcampus.ca-website-style-guide.pdf"
  • Image assets folder containing all required images for development – Folder file name "image assets"
    8 events content-desktop
    8 events content-mobile

BCcampus.ca template markup 8.pdf

@alex-418 alex-418 self-assigned this Sep 14, 2018
@alex-418 alex-418 mentioned this issue Sep 14, 2018
@alex-418
Copy link
Contributor

@murphybarb Had a lot of questions about this one. I applied some styling via #195 to get closer to the design, but was not comfortable with removing the following functionality that seems helpful without confirming that it wasn't overlooked:

  • "add to calendar" on the right-hand side
  • event taxonomy (categories, tags) at the bottom of event details section
  • tag that signals if it's an all-day event
  • "calendar" on the right-hand site
  • email link in contact
  • event website link

If the desired behavior is to remove all of this functionality, it'll add significant overhead because the plugin only lets us modify this by creating a child theme in the plugin directory itself, not in our theme. Details of that. This is not ideal, because we do not version control (in GitHub) plugin files, therefore it's not part of our deployment workflow. The impact of this means a manual process to get our new "plugin theme" files onto cert and prod.

Event images:
I did not add the image to the event as per design, the reason being when I looked at existing events images, they were not the appropriate size/aspect ratio. They are mostly banners or smaller images. This would not work with the design on single event pages, or for the featured event image as well across the site. For example, the single event page requires an image with a fixed height/width and be 50% of the event containers horizontal width. This is also not ideal due to the varying image dimensions, and height of the event container changing, depending on how many of the event details are filled out. Hope that makes sense... hope to get back or find an option that would work well with varying image sizes, and varying event details (which impacts the height of the div).

@alex-418 alex-418 removed their assignment Sep 14, 2018
@alex-418
Copy link
Contributor

@stargraphicdesign please see my comment above

@stargraphicdesign
Copy link

I can't find any working pages to look at re:this

Also I'm assuming that you just meant you wanted me to comment on the image thing.

I planned a lot of my images on the site to utilize a background-cover, flexing and cropping to their space. The images for events will accommodate this new design going forward so i'm not worried about old content, and a set of default images has been chosen for any event that the user doesn't have a photo available for.

@alex-418
Copy link
Contributor

@ehbeattie Confirmed that we are ignoring the mockup which removes essential functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants