Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year 2017 is always taken for reference when generating loads #45

Open
BDonnot opened this issue Feb 25, 2022 · 2 comments
Open

Year 2017 is always taken for reference when generating loads #45

BDonnot opened this issue Feb 25, 2022 · 2 comments

Comments

@BDonnot
Copy link
Collaborator

BDonnot commented Feb 25, 2022

When you want to generate loads for a given period, for example with:

chronix2grid --mode RL --output-folder /home/donnotben/Documents/chronix2grid_gaetan/getting_started/experiments/../example/custom/output --input-folder /home/donnotben/Documents/chronix2grid_gaetan/getting_started/experiments/../example/custom/input --ignore-warnings --weeks 1 --case case118_l2rpn_wcci_benjamin --n_scenarios 1 --start-date 2048-06-01 --seed-for-loads 1791095845  --seed-for-res 1616579073

The 2048-06-01 is a monday. However the load profile for this command is:

20220225_Load_generee

Which clearly starts a Thursday (week-end after 2 days) and NOT a monday.

The profile is obtained regardless of the year.

@BDonnot BDonnot changed the title Year 2012 is always taken for reference when generating loads Year 2017 is always taken for reference when generating loads Feb 25, 2022
@BDonnot
Copy link
Collaborator Author

BDonnot commented Mar 23, 2022

The current behaviour is to hard code in the compute_loads function the lag (in number of days).

It is currently set to 6 corresponding to a "proper year" 2050

@marota
Copy link
Collaborator

marota commented Mar 23, 2022

Day_lag has been introduced to deal with that.
https://github.com/BDonnot/ChroniX2Grid/blob/237a41ccce77cd60e91bb154f24e0e6996aa58db/chronix2grid/generation/consumption/consumption_utils.py#L27

But still need a bit of work to work properly end-to-end. For now it is hard coded to day_lag=6 for year 2050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants