Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade BHoM_Adapter to .Net Standard 2.0 #308

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Upgrade BHoM_Adapter to .Net Standard 2.0 #308

merged 4 commits into from
Oct 1, 2021

Conversation

FraserGreenroyd
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Sep 30, 2021
@FraserGreenroyd FraserGreenroyd added this to In Progress in SCRUM Pull Request Tracker via automation Sep 30, 2021
@FraserGreenroyd FraserGreenroyd self-assigned this Sep 30, 2021
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 30, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 30, 2021

Please be advised that the check with reference 3757335123 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 362 additional annotations waiting, made up of 362 errors and 0 warnings.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 30, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 30, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 30, 2021

Please be advised that the check with reference 3758641416 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 34 additional annotations waiting, made up of 34 errors and 0 warnings.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

IsakNaslundBh
IsakNaslundBh approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Compiles with structural adapters, and all tested with them. All looks fine

SCRUM Pull Request Tracker automation moved this from In Progress to Reviewer approved Oct 1, 2021
@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review October 1, 2021 15:27
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check documentation-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • core
  • documentation-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check project-compliance
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • project-compliance
  • null-handling
  • serialisation
  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 3edb97b into main Oct 1, 2021
@FraserGreenroyd FraserGreenroyd deleted the BHoM-#1291-NetStandard branch October 1, 2021 16:06
SCRUM Pull Request Tracker automation moved this from Reviewer approved to Completed Oct 1, 2021
@IsakNaslundBh IsakNaslundBh mentioned this pull request Oct 6, 2021
Merged
@FraserGreenroyd FraserGreenroyd added type:external-api-changes Imposed changes, including from dependency across other BHoM repos and removed type:feature New capability or enhancement labels Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

@alelom alelom Awaiting requested review from alelom

@enarhi enarhi Awaiting requested review from enarhi

@al-fisher al-fisher Awaiting requested review from al-fisher

@adecler adecler Awaiting requested review from adecler

@RichardWhitfield RichardWhitfield Awaiting requested review from RichardWhitfield

@michaelhoehn michaelhoehn Awaiting requested review from michaelhoehn

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
SCRUM Pull Request Tracker
  
Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FraserGreenroyd @IsakNaslundBh