Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade BHoM_Engine to .Net Standard 2.0 #2634

Merged
merged 6 commits into from
Oct 1, 2021
Merged

Upgrade BHoM_Engine to .Net Standard 2.0 #2634

merged 6 commits into from
Oct 1, 2021

Conversation

FraserGreenroyd
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1292

@FraserGreenroyd FraserGreenroyd added type:external-api-changes Imposed changes, including from dependency across other BHoM repos status:WIP PR in progress and still in draft, not ready for formal review labels Sep 30, 2021
@FraserGreenroyd FraserGreenroyd self-assigned this Sep 30, 2021
FraserGreenroyd
FraserGreenroyd commented Sep 30, 2021
View reviewed changes
Structure_Engine/Create/Loads/GeometricalLineLoad.cs
@@ -42,7 +42,7 @@ public static partial class Create
[Description("Creates a GeometricalLineLoad with a constant force across the length of the Line.")]
[InputFromProperty("location")]
[InputFromProperty("loadcase")]
[Input("force", "The force to be applied to the full length of the Line.", typeof(Force))]
[Input("force", "The force to be applied to the full length of the Line.", typeof(BH.oM.Quantities.Attributes.Force))]
Copy link
Contributor Author

@FraserGreenroyd FraserGreenroyd Sep 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IsakNaslundBh FYI - this was a compilation issue which having the full namespace resolved hence a code change in this PR for you to be particularly aware of as it's your engine.

@FraserGreenroyd FraserGreenroyd mentioned this pull request Sep 30, 2021
Merged
@bhombot-ci
Copy link

bhombot-ci bot commented Sep 30, 2021

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Adapter

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Sep 30, 2021

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Adapter

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Adapter

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Adapter

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Adapter

@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review October 1, 2021 14:27
@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Oct 1, 2021 •
edited
Loading

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

IsakNaslundBh
IsakNaslundBh reviewed Oct 1, 2021
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Compiles with structural adapters, and all tested with them. All looks fine

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check serialisation
@BHoMBot check null-handling
@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • serialisation
  • null-handling
  • copyright-compliance
  • dataset-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • dataset-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • null-handling

michaelhoehn
michaelhoehn approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check project-compliance
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • project-compliance
  • null-handling
  • serialisation
  • ready-to-merge

@FraserGreenroyd FraserGreenroyd removed the status:WIP PR in progress and still in draft, not ready for formal review label Oct 1, 2021
@FraserGreenroyd FraserGreenroyd merged commit 50ddc7a into main Oct 1, 2021
@FraserGreenroyd FraserGreenroyd deleted the BHoM-#1291-NetStandard branch October 1, 2021 16:06
@michaelhoehn michaelhoehn restored the BHoM-#1291-NetStandard branch October 5, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh IsakNaslundBh left review comments

@michaelhoehn michaelhoehn michaelhoehn approved these changes

@enarhi enarhi Awaiting requested review from enarhi

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@adecler adecler Awaiting requested review from adecler adecler is a code owner

@RichardWhitfield RichardWhitfield Awaiting requested review from RichardWhitfield

@alelom alelom Awaiting requested review from alelom alelom is a code owner

@epignatelli epignatelli Awaiting requested review from epignatelli

@kayleighhoude kayleighhoude Awaiting requested review from kayleighhoude kayleighhoude is a code owner

@pawelbaran pawelbaran Awaiting requested review from pawelbaran pawelbaran is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FraserGreenroyd @IsakNaslundBh @michaelhoehn