Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for pulling results with filter request and Add PierAndSpandrelResultRequest #334

Merged
merged 4 commits into from
Aug 12, 2020
Merged

Remove support for pulling results with filter request and Add PierAndSpandrelResultRequest #334

merged 4 commits into from
Aug 12, 2020

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Aug 10, 2020 •
edited
Loading

NOTE: Depends on

BHoM/BHoM_Adapter#244

Issues addressed by this PR

Closes #331

Removing support for pulling results with filter request, instead raising error stating what request that should be used.

Test files

Test pulling PierForce:
https://burohappold.sharepoint.com/:f:/s/BHoM/EhPTvbEYls9GoAHZ5LAAK1MB323kFzdSJSV9DwlWcEolAg?e=rh9KTR

Testing that error messages show up:
https://burohappold.sharepoint.com/:f:/s/BHoM/EpJzc3cX8wxFlD34ESjLjX4BepFblb73yqAEWHe8l1GuDA?e=iuLZct

For testing general results functionality:
https://burohappold.sharepoint.com/:f:/s/BHoM/EqqZu_1Sr0lIkfBdRPg8TBQBBsLM3bh3YedOFyiiI5-_tA?e=Ri0dJ9

Changelog

  • Disabling pulling results with FIlterRequest, instead returning error stating what needs to be done
  • Adding in PierAndSpandrelForceRequest for pulling PierForces
  • Updating namespace of PierForce to Results namespace instead of Elements

Additional comments

@IsakNaslundBh IsakNaslundBh added type:compliance Non-conforming to code guidelines type:feature New capability or enhancement labels Aug 10, 2020
@IsakNaslundBh IsakNaslundBh self-assigned this Aug 10, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.3 β MVP milestone Aug 10, 2020
@IsakNaslundBh IsakNaslundBh added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Aug 10, 2020
JosefTaylor
JosefTaylor approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsakNaslundBh
Copy link
Contributor Author

/azp run ETABS_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh IsakNaslundBh removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Aug 12, 2020
@IsakNaslundBh IsakNaslundBh merged commit 409c53f into master Aug 12, 2020
@IsakNaslundBh IsakNaslundBh deleted the BHoM_Adapter-#240-RemoveSupportForPullingResultsWithFilterRequest branch August 12, 2020 15:24
@IsakNaslundBh IsakNaslundBh mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosefTaylor JosefTaylor JosefTaylor approved these changes

@alelom alelom Awaiting requested review from alelom

@emidio-piermarini emidio-piermarini Awaiting requested review from emidio-piermarini

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:compliance Non-conforming to code guidelines type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 3.3 β MVP
Development

Successfully merging this pull request may close these issues.

Etabs_Toolkit: Remove support for pulling Results using a FilterRequest
2 participants
@IsakNaslundBh @JosefTaylor