Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align to BHoM_Adapter's AdapterId() method change #380

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

alelom
Copy link
Member

@alelom alelom commented Mar 1, 2021

NOTE: Depends on

BHoM/BHoM_Adapter#287

Issues addressed by this PR

Closes #379

The ETABS adapter was relying on the non-generic AdapterId() method to get the Id of the objects. While this is not wrong per se, that method has now been renamed to AdapterIds() (note the s) to highlight the fact that it may return more than only one Id, depending on whether multiple Ids have been stored on the object.
As this adapter currently does not need to use that feature, this PR simply replaces it with calls to AdapterId<T>().

Test files

Testing of existing functionality is needed to make sure that everything works as before.

Changelog

Additional comments

Copy link
Contributor

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an issue with updating, appearing to affect only panels, however this is the same behavior before and after this change. All else is working!

@JosefTaylor
Copy link
Contributor

@BHoMBot check-installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 1, 2021

@JosefTaylor sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For example, if you would like me to fix the CSProject file(s) comment:

"@BHoMBot fix project file"

@JosefTaylor
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 1, 2021

@JosefTaylor to confirm, check-installer task is now queued.

@JosefTaylor
Copy link
Contributor

@BHoMBot check copyright

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 1, 2021

@JosefTaylor to confirm, check-copyright-compliance task is now queued.

@JosefTaylor JosefTaylor merged commit f8aa5ba into master Mar 1, 2021
@JosefTaylor JosefTaylor deleted the BHoM_Adapter-#284-twoIdMethods branch March 1, 2021 18:44
@alelom
Copy link
Member Author

alelom commented Mar 2, 2021

Apologies, I should have set the do-not-merge tag on this PR, as it depends on the yet-to-merge BHoM/BHoM_Adapter#287!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align to BHoM_Adapter's AdapterId() method change
2 participants