-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align to BHoM_Adapter's AdapterId() method change #380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an issue with updating, appearing to affect only panels, however this is the same behavior before and after this change. All else is working!
@BHoMBot check-installer |
@JosefTaylor sorry, I didn't understand. "@BHoMBot fix project file" |
@BHoMBot check installer |
@JosefTaylor to confirm, |
@BHoMBot check copyright |
@JosefTaylor to confirm, |
Apologies, I should have set the |
NOTE: Depends on
BHoM/BHoM_Adapter#287
Issues addressed by this PR
Closes #379
The ETABS adapter was relying on the non-generic
AdapterId()
method to get the Id of the objects. While this is not wrong per se, that method has now been renamed toAdapterIds()
(note the s) to highlight the fact that it may return more than only one Id, depending on whether multiple Ids have been stored on the object.As this adapter currently does not need to use that feature, this PR simply replaces it with calls to
AdapterId<T>()
.Test files
Testing of existing functionality is needed to make sure that everything works as before.
Changelog
Additional comments