Adapter_Engine: Avoid signature duplication for AdapterId() methods

[alelom]

Dependant PRs

• SAP2000 needs alignment to this PR, done in Align to BHoM_Adapter's AdapterId() method change SAP2000_Toolkit#200.
• ETABS needs alignment to this PR, done in Align to BHoM_Adapter's AdapterId() method change ETABS_Toolkit#380

Issues addressed by this PR

Closes #284
Closes #288

This PR revises the two methods that get the AdapterId of a specific fragment Type out of a given BHoMObject.
Both methods are useful and need to be maintained, but due to the conflict explained in #284 they had to be renamed/revised.

We have:

1. a non generic method AdapterId(this BHoMObject, ...) that returns object. This gathers all IDs that implement a certain fragment type. If multiple IDs are found, a List is returned. If one Id is found, only that is returned.
   This method was renamed to AdapterIds<T>(this BHoMObject, ...) (note the s).
2. a generic method that does a similar thing, but also tries to cast to the requested type <T>. This method will return an error if multiple IDs are found. This method was slightly modified to expose more useful errors/warnings and better distinguish its function from the other one. The method was not renamed.

There are only 2 Toolkits that requires alignment (SAP2000/ETABS) because they have a reference to the renamed method (1).

All other Adapter Toolkits needs to be tested to make sure that the functionality is still working as expected.

Test files

Needs testing of existing functionality on all Adapters.

Changelog

Additional comments

[pawelbaran]

I will not approve not to give a false impression that this PR has been tested extensively, but can confirm that Revit_Toolkit works perfectly fine on this branch.

[pawelbaran]

Not sure whether it is fully relevant to this PR, but I have just raised #288 - being on this branch, I received a massive pushback from the users who were not able to extract any Ids without help. This tells me the UX will need further improvement once #284 is resolved.

[alelom]

Not sure whether it is fully relevant to this PR, but I have just raised #288 - being on this branch, I received a massive pushback from the users who were not able to extract any Ids without help. This tells me the UX will need further improvement once #284 is resolved.

See my reply there.

[IsakNaslundBh]

@BHoMBot check versioning

[bhombot-ci]

@IsakNaslundBh to confirm, check-versioning task is now queued.

[IsakNaslundBh]

Sorry for not reviewing... Been swamped!

Code changes generally look fine to me just looking here at github, but have not tested it yet.

Would assume this would require versioning, some PreviousVersion attributes to both of the updated methods!

[alelom]

/azp run BHoM_Adapter.CheckInstaller

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[alelom]

Would assume this would require versioning, some PreviousVersion attributes to both of the updated methods!

Thanks, actually only one method has been modified (AdapterId), the other (AdapterIds) is new. Will add versioning for it.

[peterjamesnugent]

This works for Lusas, both Push/Pull for various objects.

I am running in to an issue when pushing to MidasCivil though on this line:

BHoM_Adapter/BHoM_Adapter/CRUD/IRead.cs

Line 100 in e80ed0b

IEnumerable<IBHoMObject> objects = IRead(type, null as List<object>, actionConfig);

System.MissingMethodException: 'Method not found: '!!0 BH.Engine.Adapter.Query.AdapterId(BH.oM.Base.IBHoMObject, System.Type)'.'

Basically it's the first read before it pushes (so should just be empty).

System.MissingMethodException
HResult=0x80131513
Message=Method not found: '!!0 BH.Engine.Adapter.Query.AdapterId(BH.oM.Base.IBHoMObject, System.Type)'.
Source=MidasCivil_Adapter
StackTrace:
at BH.Adapter.MidasCivil.MidasCivilAdapter.ReadBars(List`1 ids)
at BH.Adapter.MidasCivil.MidasCivilAdapter.IRead(Type type, IList ids, ActionConfig actionConfig)
at BH.Adapter.BHoMAdapter.Read(Type type, String tag, ActionConfig actionConfig) in C:\Users\pnugent\Documents\GitHub\BHoM_Adapter\BHoM_Adapter\CRUD\IRead.cs:line 100

Script is here if you want to give it a try and debug:
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/Archive/MidasCivil_Toolkit/MidasCivil_Toolkit-%23263/Elements?csf=1&web=1&e=erZTfB

[peterjamesnugent]

Tested for both Lusas and Midas, able to Push/Pull a number of different objects.

[IsakNaslundBh]

Works fine now!

Need to get BHoM/SAP2000_Toolkit#209 merged first, then this should be good to go!

[IsakNaslundBh]

/azp run BHoM_Adapter.CheckInstaller

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[alelom]

/azp run BHoM_Adapter.CheckInstaller

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[IsakNaslundBh]

Re-approving

[alelom]

Replaced with #290 due to: