HDF5 1.10.x: Switch to checking defines instead of an enum #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdevenyi
changed the title
dzenanz
approved these changes
Aug 9, 2018
|
@vfonov will you do an update to ITK's MINC or shall I? |
|
go ahead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that HDF5 1.10 uses an typedef enum to define H5F_LIBVER_V18 so this code wasn't properly working.
I went back through the history of HDF5 releases and H5_VERS_MAJOR and H5_VERS_MINOR have been defines since long before 1.8 so this is a forward and backward compatible solution.