Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of lintr config copy #40

Merged
merged 1 commit into from
Feb 22, 2018
Merged

get rid of lintr config copy #40

merged 1 commit into from
Feb 22, 2018

Conversation

mschilli87
Copy link
Collaborator

@codecov-io
Copy link

codecov-io commented Apr 25, 2017

Codecov Report

Merging #40 into dev2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             dev2      #40   +/-   ##
=======================================
  Coverage   61.07%   61.07%           
=======================================
  Files          10       10           
  Lines         763      763           
=======================================
  Hits          466      466           
  Misses        297      297

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b55f5d...01fb6a2. Read the comment docs.

@mschilli87
Copy link
Collaborator Author

@retaj: This also finally runs without error.

So please go ahaed and merge if it looks good to you.

@mschilli87
Copy link
Collaborator Author

I have no idea why this triggered windows testing.
The dev branch works and the only difference between dev and lint is cd46991.
I'll investigate and update again.

@mschilli87
Copy link
Collaborator Author

closing to re-open to get rid of win testing

@mschilli87 mschilli87 closed this May 11, 2017
@mschilli87 mschilli87 reopened this May 11, 2017
@mschilli87
Copy link
Collaborator Author

@retaj: So it seams like the windows test is somehow left as at some point you merged the wintest branch into dev and appveyor doesn't get that there is no appveyor.yml anymore in either of the branches.

I don't know how to change this and I don't think its worth the time finding out.
As there should be no windows testing done on the PR, we can safely ignore that it fails.

So please go ahead and merge this.
As there is no windows testing on dev everything will be fine once this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants