Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend redirects from Craft rather than append them #18

Open
weotch opened this issue Mar 16, 2023 · 0 comments
Open

Prepend redirects from Craft rather than append them #18

weotch opened this issue Mar 16, 2023 · 0 comments

Comments

@weotch
Copy link
Member

weotch commented Mar 16, 2023

These should take precedence over hardcoded rules since they were explicitly made. For instance, if appending, you might have this

/articles/* /articles-in-german/:splat 301
/articles/english-slug /articles-in-german/german-slug 301

Then, if a user went to https://domain.com/articles/english-slug, they would be redirected to https://domain.com/articles-in-german/english-slug, which would 404.

If prepending, then you end up with:

/articles/english-slug /articles-in-german/german-slug 301
/articles/* /articles-in-german/:splat 301

And then user would be redirected to https://domain.com/articles-in-german/german-slug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weotch