Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove console log #123

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Remove console log #123

merged 2 commits into from
Jun 7, 2023

Conversation

lemoswilson
Copy link
Contributor

@lemoswilson lemoswilson commented Jun 7, 2023

Just noticed that I did not remove a console log call I had added to inspect the code 😅 sorry bout that.

I can publish a new package version myself if you are ok with that, just let me know.

@codesandbox
Copy link

codesandbox bot commented Jun 7, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@lemoswilson lemoswilson requested a review from weotch June 7, 2023 22:27
@netlify
Copy link

netlify bot commented Jun 7, 2023

Deploy Preview for vue-ssr-carousel ready!

Name Link
🔨 Latest commit 035a56b
🔍 Latest deploy log https://app.netlify.com/sites/vue-ssr-carousel/deploys/648104695ebaf5000845c2a6
😎 Deploy Preview https://deploy-preview-123--vue-ssr-carousel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Jun 7, 2023

Passing run #73 ↗︎

0 18 0 0 Flakiness 0

Details:

run webpack
Project: vue-ssr-carousel Commit: 035a56b897
Status: Passed Duration: 03:45 💡
Started: Jun 7, 2023 10:28 PM Ended: Jun 7, 2023 10:32 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@weotch weotch merged commit aa40a87 into main Jun 7, 2023
5 checks passed
@weotch weotch deleted the remove-console-log branch June 7, 2023 22:43
@weotch
Copy link
Member

weotch commented Jun 7, 2023

Oh yeah, go ahead on publish 👍

@lemoswilson
Copy link
Contributor Author

image

Turns out I can't publish this one package, maybe it's not under the npm bklwd org?

@weotch
Copy link
Member

weotch commented Jun 8, 2023

I published it this morning but I also added you to npm for the package as well

@lemoswilson
Copy link
Contributor Author

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants