Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL support via changing slide order #137

Merged
merged 10 commits into from
Jan 20, 2024
Merged

RTL support via changing slide order #137

merged 10 commits into from
Jan 20, 2024

Conversation

weotch
Copy link
Member

@weotch weotch commented Jan 20, 2024

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jan 20, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@netlify Netlify
Copy link

netlify bot commented Jan 20, 2024 •
edited
Loading

✅ Deploy Preview for vue-ssr-carousel ready!

Name Link
🔨 Latest commit deaa201
🔍 Latest deploy log https://app.netlify.com/sites/vue-ssr-carousel/deploys/65ab24b1b515f00007c35f43
😎 Deploy Preview https://deploy-preview-137--vue-ssr-carousel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Jan 20, 2024 •
edited
Loading

Passing run #101 ↗︎

0 18 0 0 Flakiness 0

Details:

Fix dot label when not RTL
Project: vue-ssr-carousel Commit: deaa20135a
Status: Passed Duration: 01:18 💡
Started: Jan 20, 2024 1:42 AM Ended: Jan 20, 2024 1:43 AM

Review all test suite changes for PR #137 ↗︎

@weotch weotch merged commit cb3309c into main Jan 20, 2024
7 checks passed
@weotch weotch deleted the rtl-support-via-changing-slide-order branch January 20, 2024 01:46
weotch
weotch commented Jan 22, 2024
View reviewed changes
src/ssr-carousel.vue
Comment on lines +173 to +175
// Internal logic expects ltr layout
direction ltr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azerozvn I realized one possible issue with this change. I'm setting the direction of the carousel wrapper to ltr so that my reversing of the order works as intended. However, this means that the slides will inherit this setting.

Like notice how the slide titles here are ltr:

image

I want to release a patch fix that sets the carousel track contents to direction: rtl when the rtl prop of the container is set. See any issue with that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright @azerozvn this change was released as v2.4.1 if you wanna upgrade to it. See #138.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and sorry I forgot to answer you here, I've updated sites-rtl to use 2.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azerozvn azerozvn azerozvn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weotch @azerozvn