Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support taproot script-path spendings #10

Open
crisdut opened this issue Dec 22, 2023 · 5 comments
Open

Support taproot script-path spendings #10

crisdut opened this issue Dec 22, 2023 · 5 comments
Milestone

Comments

@crisdut
Copy link
Member

crisdut commented Dec 22, 2023

Description

Currently, the TapTree::merkle_root is not implemented. This causes error during transfer creation step in RGB v0.11:

RGB: command-line wallet for RGB smart contracts
     by LNP/BP Standards Association

Loading descriptor from wallet default ... success
Loading stock ... success
thread 'main' panicked at 'not yet implemented', /bp-std/derive/src/taptree.rs:144:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Type: bug
Version: a200597

@crisdut crisdut changed the title Implement merkle_root in Taptree Missing merkle_root implementation in Taptree Dec 22, 2023
@dr-orlovsky
Copy link
Member

Partially closed in 4a234b9

@crisdut
Copy link
Member Author

crisdut commented Dec 26, 2023

I'm going to close this issue, okay?

@dr-orlovsky
Copy link
Member

Nope - script part is not yet implemented.

@dr-orlovsky dr-orlovsky added this to the v0.11.x milestone Sep 5, 2024
@St333p
Copy link

St333p commented Oct 29, 2024

Does this issue also cover the addition of a tapret commitment to a non-empty taptree, in which a nonce is used to ensure unique position of the tapret leaf as described in LNPBP12?

@dr-orlovsky dr-orlovsky changed the title Missing merkle_root implementation in Taptree Support taproot script-path spendings Oct 31, 2024
@dr-orlovsky
Copy link
Member

@St333p Basically this issue is because there is no taproot implementation for script path spendings. So this is unrelated to RGB - it is just the fact that RGB when tries to build taproot tree fails (since it is not yet supported)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants