Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a thorough review of files and folders to delete in services.json #223

Closed
Shettland opened this issue Apr 10, 2024 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Shettland
Copy link
Member

Some templates have been updated (leaving the latter files/folders outdated) while others do not have the proper files/samples to clean correctly assigned from the beggining in services.json.
e.g. In assembly template, the name of the folder is now "01-processing"
["folders":["01-preprocessing/trimmed_sequences"],](

"folders":["01-preprocessing/trimmed_sequences"],
)

@Shettland Shettland added help wanted Extra attention is needed enhancement New feature or request labels Apr 10, 2024
@Shettland Shettland self-assigned this Apr 17, 2024
@jaimeozaez
Copy link
Member

jaimeozaez commented May 30, 2024

Here there is a problem. When we run the “finish” function of the buisciii-tools, it runs first clean, then scratch_to_service, then rename_no_copy and finally the copy-sftp.

The point is that the clean function (which is executed in scratch) includes the _DEL tag in the folders that have been emptied, but there is still a copy of the same folder in /data/bi, and this folder remains unrenamed, so it ends up being copied to the sftp.

Maybe it would be a good option to include the renaming (_DEL) of the folders inside the rename_no_copy function.

@jaimeozaez
Copy link
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants