Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 #727

Open
AntonOfTheWoods opened this issue Oct 25, 2022 · 7 comments
Open

Add support for Python 3.11 #727

AntonOfTheWoods opened this issue Oct 25, 2022 · 7 comments

Comments

@AntonOfTheWoods
Copy link
Contributor

Now that Python 3.11 is properly released and supported, OpenCC should support it.

@ayaka14732
Copy link
Collaborator

@BYVoid Please set @AntonOfTheWoods as an administrator!

@AntonOfTheWoods
Copy link
Contributor Author

Actually, sorry I was a bit messy on this... I assumed it would work out of the box like 3.10 but there have been some (performance) changes that require updating deps. I've converted the PR to a draft and will make sure things work properly before resubmitting!

@AntonOfTheWoods
Copy link
Contributor Author

And conda is used to build, so we may have to wait weeks (conda-forge/python-feedstock#577 is the first step I guess).

AntonOfTheWoods added a commit to AntonOfTheWoods/OpenCC that referenced this issue Dec 2, 2022
As the Anaconda folks can take months (or even years) to support new
versions of python, also move to the conda-forge upstream repo, which is
both much quicker and also the source of truth for the standard
packages.
ayaka14732 pushed a commit that referenced this issue Dec 4, 2022
As the Anaconda folks can take months (or even years) to support new
versions of python, also move to the conda-forge upstream repo, which is
both much quicker and also the source of truth for the standard
packages.
@ThanatosDi
Copy link

@AntonOfTheWoods Hi, I try install opencc with poetry and python is 3.11 but poetry will return error Unable to find installation candidates for opencc (1.1.6) then I goto pypi and found that, there don't have wheel for windows amd64

this is my install debug message

Skipping wheel OpenCC-1.1.6-cp310-cp310-macosx_10_9_x86_64.whl as this is not supported by the current environment
Skipping wheel OpenCC-1.1.6-cp310-cp310-manylinux1_x86_64.whl as this is not supported by the current environment
Skipping wheel OpenCC-1.1.6-cp311-cp311-macosx_10_9_x86_64.whl as this is not supported by the current environment
Skipping wheel OpenCC-1.1.6-cp311-cp311-manylinux1_x86_64.whl as this is not supported by the current environment
Skipping wheel OpenCC-1.1.6-cp37-cp37m-macosx_10_9_x86_64.whl as this is not supported by the current environment
Skipping wheel OpenCC-1.1.6-cp37-cp37m-manylinux1_x86_64.whl as this is not supported by the current environment
Skipping wheel OpenCC-1.1.6-cp38-cp38-macosx_10_9_x86_64.whl as this is not supported by the current environment
Skipping wheel OpenCC-1.1.6-cp38-cp38-manylinux1_x86_64.whl as this is not supported by the current environment
Skipping wheel OpenCC-1.1.6-cp39-cp39-macosx_10_9_x86_64.whl as this is not supported by the current environment
Skipping wheel OpenCC-1.1.6-cp39-cp39-manylinux1_x86_64.whl as this is not supported by the current environment

  Stack trace:

  5  ~\AppData\Local\Programs\Python\Python311\Lib\site-packages\poetry\installation\executor.py:261 in _execute_operation

@AntonOfTheWoods
Copy link
Contributor Author

@ThanatosDi , weird, it looks like the windows script may report success, even if it completely fails to upload. That's annoying! I'll have a look.

@ThanatosDi
Copy link

ThanatosDi commented Dec 13, 2022

@AntonOfTheWoods Is anything good news?
I see the Github Action build log for windows, there had many error alert
for example
image

but the build still complete, it so weird

@AntonOfTheWoods
Copy link
Contributor Author

Sorry @ThanatosDi , this looks like a simple flaky build. I have created separate builds for each platform to get around this issue on a temporary basis.

The massive amount of errors is actually just a bug with windows docker instances that has apparently been happening since at least 2019. It's "just a logging issue" but obviously it makes actually using the logs in case of an issue almost impossible. Sigh.

The entire build system could do with a refresh and add the actual build process to each commit. That is a little more work though and was putting it off until python 3.12 :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants