Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.11.0 #577

Merged
merged 16 commits into from
Oct 25, 2022
Merged

3.11.0 #577

merged 16 commits into from
Oct 25, 2022

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Aug 23, 2022 •
edited
Loading

  • Remove CONDA_DLL_SEARCH_MODIFICATION=1 codepath as it's not needed anymore

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf
Copy link
Member Author

isuruf commented Aug 23, 2022

@conda-forge-admin, rerender

@mariusvniekerk
Copy link
Member

Looks like the downstreams tests are failing

@mattwthompson mattwthompson mentioned this pull request Sep 13, 2022
Closed
@cclauss
Copy link

cclauss commented Sep 13, 2022

Upgrade to rc2? https://www.python.org/download/pre-releases/

katietz
katietz reviewed Sep 13, 2022
View reviewed changes
recipe/meta.yaml Show resolved Hide resolved
recipe/conda_build_config.yaml
cxx_compiler: # [win]
- vs2017 # [win]
vc: # [win]
- 14.1 # [win]
MACOSX_SDK_VERSION: # [osx and x86_64]
- 11.0 # [osx and x86_64]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended? We can built it pretty nicely with 10.14 SDK on osx-64

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's intended. Building with 10.14 will give you a python interpreter that's broken on 11.0. For eg: #575

Copy link

@danpetry danpetry Sep 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, using 11.0 doesn't build for intel 64 macos here. It was ok when building python 3.10.4 but not python 3.11. We're having a look at why, if you have any insights that would be great.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, using 11.0 doesn't build for intel 64 macos here.

I don't understand what you are saying here. Details please.

Copy link

@danpetry danpetry Sep 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use macOS SDK version 11.0, we can't build python 3.11 for the osx-64 target. (which is 64-bit intel CPU Mac). However, for previous versions of Python (we're on 3.10.4 at the moment), we successfully used SDK version 11.0 to build for all targets (both ARM and Intel mac).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the error when you use SDK 11.0?

Copy link

@danpetry danpetry Sep 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/var/folders/sy/f16zz6x50xz3113nwtb9bvq00000gp/T/abs_2092500kee/croots/recipe/python-split_1663247373378/work/Objects/longobject.c:5693:5: error: implicit declaration of function 'static_assert' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

The only change between a package that builds successfully, and one which fails with this message, is changing the SDK version from 10.14 to 11.0. This is when building Python v3.11 rc 1, for osx-64. When building the same feedstock for osx-arm64, using SDK version 11.0, the build completes successfully.

The static_assert call in question was added somewhere between Python v3.10.4 and v3.11.

Copy link
Member

@h-vetinari h-vetinari Oct 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implicit declaration of function 'static_assert' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

That's a consequence of upstream python switching to C11, which introduces a static_assert macro (xref upstream conversion PR).

Have you verified that you're compiling with -std=c11?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That topic is also discussed quite extensively in python/cpython#91731

@danpetry danpetry mentioned this pull request Sep 14, 2022
Merged
3 tasks
@chrisburr chrisburr mentioned this pull request Sep 29, 2022
Closed
@lrineau lrineau mentioned this pull request Oct 5, 2022
Merged
@isuruf isuruf changed the title 3.11.0rc1 3.11.0 Oct 25, 2022
This was referenced Oct 25, 2022
Closed
Closed
@AntonOfTheWoods AntonOfTheWoods mentioned this pull request Oct 25, 2022
Open
chrisburr
chrisburr approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@chrisburr chrisburr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a 3.10 branch based on the current master and am about to re-target the existing PRs.

@chrisburr chrisburr merged commit ef72f59 into conda-forge:main Oct 25, 2022
@isuruf isuruf deleted the 3.11.0rc1 branch October 25, 2022 06:53
@jakirkham
Copy link
Member

Guess the next step is starting a migration, added a draft PR ( conda-forge/conda-forge-pinning-feedstock#3573 ) to get this started. Feedback welcome 🙂

@chrisburr
Copy link
Member

I've also updated python_abi conda-forge/python_abi-feedstock#16 as I'm fairly sure the bot isn't able to.

@cbouss cbouss mentioned this pull request Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danpetry danpetry danpetry left review comments

@h-vetinari h-vetinari h-vetinari left review comments

@katietz katietz katietz left review comments

@chrisburr chrisburr chrisburr approved these changes

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@mbargull mbargull Awaiting requested review from mbargull mbargull is a code owner

@mingwandroid mingwandroid Awaiting requested review from mingwandroid mingwandroid is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@pelson pelson Awaiting requested review from pelson pelson is a code owner

@scopatz scopatz Awaiting requested review from scopatz scopatz is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@isuruf @conda-forge-linter @mariusvniekerk @cclauss @jakirkham @chrisburr @danpetry @h-vetinari @katietz