DeviceInputSystem: Add configure/removeEvents to be called by DeviceSourceManager #11959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghgary
requested changes
Feb 9, 2022
bghgary
requested changes
Feb 14, 2022
|
@bghgary - I leave it to you to resolve the conversations and approve |
bghgary
reviewed
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few fixes. First, the contract for DeviceInputSystem has been changed to add
configureEventsandremoveEventsas public functions. These functions will now also be called by the DeviceSourceManager, in order to enable and disable event handling. The DeviceSourceManager will also haveenableEventsanddisableEvents. These functions will call configure and remove respectively. The enable and disableEvents functions should only be called by the InputManager but can tehcnically be called by other classes or the user. Finally, the default max number of touch points ifnavigator.maxTouchPointsdoesn't exist is now 2 to support the usage of device that may be interpreted as touch but aren't touch. 2 was also picked because we only really support up to 2 finger gestures.