Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for pointer out #15255

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jul 8, 2024

See https://forum.babylonjs.com/t/clicking-through-world-ui/51905?u=raananw

The problem is that (almost) every direct call for this function is calling:

this._lastControlOver[pointerId]._onPointerOut(this._lastControlOver[pointerId], pi);, meaning it will always return unless force is passed (which isn't being passed on standard input loop).

The call that does not use the same object to the call checks beforehnd if the target and this are equal, so there is no change in the default behavior. Tested with a few UI playgrounds and seems to make no difference in standard behavior.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 8, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RaananW RaananW added the bug label Jul 8, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 8, 2024

@deltakosh deltakosh merged commit 64f370f into BabylonJS:master Jul 10, 2024
12 checks passed
@RaananW RaananW deleted the pointerOutFix branch July 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants