Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculated tangent when using right handed system #2222

Merged
merged 2 commits into from
Jun 2, 2017

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Jun 2, 2017

No description provided.

@deltakosh deltakosh merged commit db588ba into BabylonJS:master Jun 2, 2017
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this pull request Jun 2, 2017
…changes

* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).
* Babylon (like Cesium) now defaults to previewing the content in the tab as opposed to the content saved in the file, the same way it's done in this [Babylon Plaground Example](https://www.babylonjs-playground.com/#1AbIIF#7).

Resolves Issue AnalyticalGraphicsInc#15

> **Work in Progress**
> - This doesn't have a Babylon with pull 2222 since that hasn't been taken to master
> - Active preview for Babylon is not currently working for some reason.  More investgiation needs to happen.
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this pull request Jun 5, 2017
…changes

* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).
* Babylon (like Cesium) now defaults to previewing the content in the tab as opposed to the content saved in the file, the same way it's done in this [Babylon Plaground Example](https://www.babylonjs-playground.com/#1AbIIF#7).

Resolves Issue AnalyticalGraphicsInc#15

> **Work in Progress**
> - Active preview for Babylon is not currently working for some reason.  More investgiation needs to happen.
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this pull request Jun 5, 2017
* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).

Resolves Issue AnalyticalGraphicsInc#15
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this pull request Jun 5, 2017
* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).

Resolves Issue AnalyticalGraphicsInc#15
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this pull request Jun 5, 2017
* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).

Resolves Issue AnalyticalGraphicsInc#15
@bghgary bghgary deleted the fix-calc-tangent branch July 12, 2017 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants