Defining typescript interface for options of method to make screenshots #6630
Conversation
|
Could the interface be moved within the screenshotTools file ? This helps preventing import from tools in ES6 when not necessary. Thx |
|
LGTM :-) Could you add an entry in dist/preview release/what's new.md ? and all the build will be green and ready to go in. |
Seems I cant understand.. it is written here what I must not commit dist/preview |
|
This is utterly confusing I agree and I will fix the doc ASAP, the what s new file is the only one that needs to be updated. This is our base to create the changelog for the next release. |
src/Misc/tools.ts
Outdated
| @@ -15,6 +15,7 @@ import { PromisePolyfill } from './promise'; | |||
| import { TimingTools } from './timingTools'; | |||
| import { InstantiationTools } from './instantiationTools'; | |||
| import { GUID } from './guid'; | |||
| import { IScreenshotSize } from './screenshotTools'; | |||
There was a problem hiding this comment.
The only problem is that we do not want to import the file automatically for size reason (treeshacking). Do you mind moving the interface in its own file?
I wanted itm but cant understand system for defining interfaces. In my projects I usual define interfaces in self directory called |
|
iInspectable is already in the misc folder so it is ok to drop that file there as well |
But in this folder already have many interfeces, these may be moved into |
|
I agree but let's do it later then. (Also you have a doc issue) |
I thinked documentation generated automatic, it is not right? Or you about |
|
I updated file |
|
You can see the checks here: https://github.com/BabylonJS/Babylon.js/pull/6630/checks The documentation problem: "[18:09:46] Missing text for Interface : IScreenshotSize (id: 24186) babylon.d.ts:31576" |
|
Aaaand did I pass this challenge? |
|
YOU DID :) |
|
Yes! Thanks man! |
From https://forum.babylonjs.com/t/define-typescript-interface-for-options-of-method-to-make-screenshots/4713
All test are passed and build successfully complete