Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prototype of InputTextArea #8275

Closed
wants to merge 5 commits into from
Closed

Conversation

fneitzel
Copy link
Contributor

As per request I send this proposal of an InputTextArea. So one can have a multiple line InputTextField. Here is a link to the forum discussion: https://forum.babylonjs.com/t/gui-textinput-with-multiple-lines/9927

The are a quite a few things left and since I got no time in the moment, maybe others can push this forward.

What's missing:

include margin
text highlighting (copy/paste/delete)
backspace deletion

I don't know how to reolve this issue:

 [at-loader] ../../gui/src/2D/controls/inputTextArea.ts:906:55 
    TS2339: Property 'text' does not exist on type 'object'.

@deltakosh
Copy link
Contributor

deltakosh commented May 27, 2020

Hello and thanks a ton! Before going in depth I think we should consider having the textarea inheriting from InputText as they share a lot of code (to avoid duplications and maintenance hurdles)

@sebavan
Copy link
Member

sebavan commented May 27, 2020

Related to #5630

@sebavan
Copy link
Member

sebavan commented May 27, 2020

It is getting there nicely, text highlighting and the rest would be kickass :-)

@sebavan
Copy link
Member

sebavan commented Jul 3, 2020

@fneitzel do you think you will address the PR ?

@deltakosh
Copy link
Contributor

Closing for being stalled for too long

Please feel free to reopen when possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants