[gizmo] fix camera LH/RH coord + fix instanced meshes update #8844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix instanced meshes update with gizmo
CedricGuillemet
requested review from
deltakosh,
msDestiny14,
Popov72 and
RaananW
RaananW
approved these changes
Sep 1, 2020
src/Gizmos/gizmo.ts
Outdated
| } | ||
|
|
||
| if (camera.getScene().useRightHandedSystem) { | ||
| // avoid desync with RH matrix computation. Otherwise, rotation of PI around Y axis happens each frame resulting in axis flipped because worldMatrix is computed as inverse of viewMatrix. | ||
| Matrix.RotationY(Math.PI).multiplyToRef(worldMatrix, this._tempMatrix2); |
There was a problem hiding this comment.
This will create a new matrix on each frame. You can use the Temp matrix classes to calculate rotation to ref, or actually store a read-only class member with this rotation already set and reuse it whenever needed
There was a problem hiding this comment.
That's a great idea! Thanks!
Popov72
reviewed
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8784 and this issue : https://forum.babylonjs.com/t/attaching-a-gizmo-to-a-camera-with-userighthandedsystem/13532
For instanced meshes, simple check in the update matrix code.
for LH/RH:
camera worldMatrix is computed as the inverse of the viewMatrix. So, when doing a loop with gizmos (worldmatrix editing-> viewMatrix computation -> worldMatrix as the inverse), a rotation on the Y axis happens each frame giving a nice flipping effect.
Now, when decomposing translation/scaling/rotation, I compute rotation on the Y axis as if the continuity of the worldmatrix is preserved.
Also fixed the camera gizmo display mesh that didn't take RightHand coordinates into account.