Update PBR clear coat and sheen to latest spec

[Popov72]

Fix #9001.

[sebavan]

It looks like there might be a compilation issue in Webgl1

[Popov72]

Fixed

[bghgary]

I guess we don't have any validation tests for clearcoat or sheen?

[bghgary]

I'll work on updating the sample model.

[bghgary]

It's updated here: KhronosGroup/glTF-Sample-Models#266

[Popov72]

I guess we don't have any validation tests for clearcoat or sheen?

We have:

• Node material PBR 1: https://playground.babylonjs.com/#D8AK3Z#7
• PBR shader code coverage:
  • 1: https://playground.babylonjs.com/#QI7TL3#16
  • 2: https://playground.babylonjs.com/#QI7TL3#17
  • 3: https://playground.babylonjs.com/#QI7TL3#18

Those PGs are activating clearcoat and sheen.

Notably, the last 3 are testing different settings of the clearcoat and sheen modules.

Do you want me to add a validation test with the sheen asset?

[bghgary]

Do you want me to add a validation test with the sheen asset?

Are the PGs you mentioned not already in the validation tests? If not, then yes, I think we should add one. Specifically a glTF sample model.

[Popov72]

Yes, the PGs I have linked are already in the validation test list.

[bghgary]

Yes, the PGs I have linked are already in the validation test list.

I mean glTF models with clearcoat and sheen, not just clearcoat and sheen directly.

[Popov72]

Yes, the PGs I have linked are already in the validation test list.

I mean glTF models with clearcoat and sheen, not just clearcoat and sheen directly.

Ok, then no there isn't. Have you a model for the clearcoat validation test?

[bghgary]

https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/ClearCoatTest would be good.

[Popov72]

Code is updated, waiting for BabylonJS/Assets#16 to be merged before adding validation tests.

[deltakosh]

Ok Gary has a feedback on the assets so waiting to merge it

[deltakosh]

we do have some conflicts to fix (I merged the assets)

[Popov72]

Fixed and validation tests added.

[deltakosh]

it fails :(

[Popov72]

There is a 3mn timeout on the clear coat test, but it's exactly the same than for sheen which works... Only the asset is different, but it does work here: https://playground.babylonjs.com/#YG3BBF#1

[deltakosh]

@sebavan can we increase the timeout?

[Popov72]

In fact the asset is quite small for clear coat: only 233 ko...

And it is bigger for sheen: 4.86Mo in all.

clear coat asset is glb whereas it is gltf for sheen...

[Popov72]

There was a conflict with the clear coat ts file, let's see how it goes now.

[Popov72]

Still does not work, trying another PG...

[Popov72]

Well, it seems the dev server does not like the ClearCoatTest.glb asset, I can't make it to work...

[deltakosh]

Make sure there is no upper caps / lower caps issues ?

[Popov72]

It is working when using it in the PG: https://playground.babylonjs.com/#YG3BBF#1

Or https://playground.babylonjs.com/#YG3BBF#3, which is the one I tried in the latest commit.

[deltakosh]

can we try with the gltf version?

[Popov72]

Waiting for BabylonJS/Assets#17 to be in before changing the test.

[Popov72]

Same problem, timeout...

[deltakosh]

There is something wrong here adding @sebavan to have his thougths

[deltakosh]

up?

[sebavan]

Still need to look into the tests should be able to do it tomorrow night.

[Popov72]

I have excluded the clearcoat unit test from automatic testing so that the PR can be merged: @sebavan is currently looking at the problem in another PR.