Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Adding SheenCloth asset #266

Merged
merged 15 commits into from Dec 1, 2020
Merged

Adding SheenCloth asset #266

merged 15 commits into from Dec 1, 2020

Conversation

PatrickRyanMS
Copy link
Contributor

Sample asset of a cloth simulated mesh with a custom texture including a sheen texture using KHR_materials_sheen extention in the file. The mesh is heavy due to the frequency and resolution of the folds in the cloth, but we make up some ground by using 256x256 tiling textures that are tiled 30 times in U and V to maximize resolution when close.

The sheen texture is pushing multiple colors into the material based on the textile design and we are passing a custom roughness in alpha as well to control the sheen levels in the material.

The README contains some information about how the asset was made and screen captures of the asset running in the Babylon.js playground.

Sheen sample asset using the KHR sheen extension.
Fixed image link
updated name for material, mesh, bin, and glTF file as well as parent folder
fix link to screenshot
@emackey
Copy link
Member

emackey commented Jul 31, 2020

Thanks Patrick! I'll mention this model at the PBR Next meeting on Monday.

@cx20
Copy link
Contributor

cx20 commented Aug 5, 2020

I added this model to gltf-test as usual and tested it. The display results of some WebGL libraries are as follows.
Probably Babylon.js is the expected result, but at first glance it is difficult to determine which library uses the KHR_materials_sheen extension.

Library Result (small) Result (large)
three.js image image
Babylon.js image image
Filament image image
PlayCanvas image image

@bghgary
Copy link
Contributor

bghgary commented Aug 5, 2020

This model has the KHR_materials_sheen extension marked as required. Looking at the results, I'm guessing only Babylon.js currently supports this extension? If so, then implementations are not respecting the extensions required property?

Looks like that's the case:
https://github.com/KhronosGroup/glTF-Asset-Generator/tree/master/Output/Positive/Compatibility (Model 05)

@donmccurdy
Copy link
Contributor

three.js should be printing a warning about the unknown required extension, but isn't preventing the load. We don't implement KHR_materials_sheen yet.

@donmccurdy
Copy link
Contributor

Testing read/write in donmccurdy/glTF-Transform#114, this looks good to me!

Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually validated with 2.0.0-dev.3.3 pre-release (which supports sheen).

@emackey emackey merged commit 9726dcc into KhronosGroup:master Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants