Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Maya rotation animation quaternion conversion #575

Merged
merged 4 commits into from Jul 25, 2019

Conversation

Drigax
Copy link
Contributor

@Drigax Drigax commented Jul 25, 2019

This is intended to fix an issue where maya rotation animation keyframes are not accurately exported to Babylon.

Reimplemented EulerAngle->Quaternion conversion to work with all 123 euler rotation sequences that are supported by Maya. Modified the animation keyframe export process to properly reverse rotation order when changing coordinate system from RHR to LHR.

…ngle->Quaternion implementation to work with all 123 euler rotation orderes that are supported by Maya, modified animation export to flip rotation order when changing coordinate system
@Drigax Drigax requested a review from deltakosh July 25, 2019 22:48
@deltakosh
Copy link
Contributor

You need to update the branch from master

Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it! good job

@Drigax Drigax merged commit 2679593 into master Jul 25, 2019
@Drigax Drigax deleted the drigax/fixMayaRotationAnimation_rotationOrdering branch July 25, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants