Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow free choice of different display name as per the custom variant #237

Open
dileepZion opened this issue Mar 27, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@dileepZion
Copy link
Contributor

Background

  • If it is an enhancement of an existing feature, describe which feature and how it works at the moment.
  • Currently the V_APP_NAME as per the tool, works to change the Bundle name(Target name) and also the Bundle Display name.
    Hence it is not possible to use only V_APP_NAME or app_name as a parameter to switch to different names of the app.
    Currently when I have gone through the code, here is the below way to update the info.plist
    In XCConfigFactory, updateInfoPlist method has below code:
Bash("plutil", arguments: "-replace", "CFBundleName", "-string", "$(V_APP_NAME)", configFilePath),
Bash("plutil", arguments: "-replace", "CFBundleDisplayName", "-string", "$(V_APP_NAME)", configFilePath),
Bash("plutil", arguments: "-replace", "CFBundleExecutable", "-string", "$(V_APP_NAME)", configFilePath),

Solution

It is good if we only give the V_APP_NAME to CFBundleName and CFBundleExecutable and allow the user to change CFBundleDisplayName according to their own requirement. Like,
Dev -> APP_NAME_DEV
QA -> APP_NAME_QA
UAT -> APP_NAME_UAT

Thanks!

@dileepZion dileepZion added the enhancement New feature or request label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant