Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure no-console rule consistently or remove altogether #4

Closed
bertdeblock opened this issue Feb 12, 2024 · 2 comments
Closed

Configure no-console rule consistently or remove altogether #4

bertdeblock opened this issue Feb 12, 2024 · 2 comments

Comments

@bertdeblock
Copy link
Contributor

I would prefer it to be configured consistently or not at all (allow everything).
I don't think we should allow only warn and error in app code, and then allow everything in tests/dummy/**.
@gvdp
Copy link
Contributor

gvdp commented Mar 12, 2024

Removed the override in tests/dummy/** , not sure why it was there, don't think we should allow console logs there either.

@bertdeblock
Copy link
Contributor Author

bertdeblock commented Mar 19, 2024 •
edited
Loading

Why do we only allow error and warn. Why not info, debug, table, ...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bertdeblock @gvdp