Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suman | BAH-414 | Display new field section names on dashboard #10

Merged
merged 5 commits into from
May 16, 2018

Conversation

sumanmaity112
Copy link
Contributor

No description provided.

@mks-d
Copy link
Member

mks-d commented Mar 16, 2018

@sumanmaity112 this can't be merged because of conflicts, could you check?

@sravanthi17
Copy link
Contributor

@mks-d Are you already reviewing this ? The merge conflicts are resolved. If you are still on, then you can merge this PR.

@mks-d
Copy link
Member

mks-d commented May 8, 2018

I am not familiar enough with OpenELIS at this stage to review this.
@sumanmaity112 , is this something you could do?

@sumanmaity112
Copy link
Contributor Author

Hi @mks-d,
I only created this PR. So I can't review this. Maybe @sravanthi17 or @angshu can look into it.

Copy link
Member

@mks-d mks-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@binduak is this the one we discussed on Friday?

@sumanmaity112 a screenshot would be best. If I remember correctly the problem was that the notes columns was disproportionately wide.

@binduak
Copy link
Contributor

binduak commented May 15, 2018

@mks-d yes..I have updated the JIRA card with sample screenshots of the styling issue.

@binduak binduak merged commit 34244a0 into master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants