Pull bugfixes for #35 and #37 onto main #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to actually get the split string because any string with " (Worth: <amount>" in it will make the second scan trigger # case 3 and 5 when getting a "sample" scan event if the current scan progress is "1/3" or "3/3"
What was missing: In "Log" scantype event did not clear the scan 2 pos distance string. since after "Log" we only have distance 1. didn't use the proper last_scan_plant string (have to split it because of #29 ) didn't do that before was resetting distance 1 without showing everytime before I changed this. Also forgot to clear the string variable. Though I needed to adjust the case for when to update the distances. Might be doing nothing since on "1/3" plugin.AST_scan_2_pos_vector[0] will always be None. atleast now it properly checks for plugin.AST_scan_2_pos_vector. extended line in the preferences menu. no string or other ui element in there should be longer than line. readme updated so that the "new" features are not really new since they've been in two prior releases. with varying ways of them working. demoted all the logger.info calls in journalcrawler.py to logger.debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #35
fixes #37