Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request -- Add Clonal Colony Range #2

Closed
luctius opened this issue Nov 21, 2022 · 1 comment · Fixed by #15
Closed

Feature Request -- Add Clonal Colony Range #2

luctius opened this issue Nov 21, 2022 · 1 comment · Fixed by #15
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@luctius
Copy link

luctius commented Nov 21, 2022

It would be nice if the plugin shows the minimum distance we should travel before make the next scan for this species.

@Balvald Balvald added the enhancement New feature or request label Nov 25, 2022
@Balvald
Copy link
Owner

Balvald commented Nov 25, 2022

I'll wait to implement this one after I'm done with what I'm currently still brewing on my dev branch (General tracking of sold and unsold but already scanned biodata, atleast to the best of anyones abilities and current worth of scans not sold yet)

As I'd personally like it if I could check how far I've gone from the last scan while sitting in an SRV.
interpretation of this feature is to show the current distance to up to the last 2 scans.
Similar how in the Canonn plugin someone can select a surface signal and by using the proposed heading get to the place
only with the goal being to get far enough away from "temporarily" saved scan locations.

So far relevant notes for this feature as I did a little research of what it'd need:

  • Lat, Long, Heading of current position can be found in Status.json as long as the player is close enough to a planet which is generally true while scanning biodata. Should be able to get this info in the plugin via dashboard_entry(). Relevant: https://github.com/EDCD/EDMarketConnector/blob/main/PLUGINS.md#player-dashboard
  • Need the current planets radius to compute distance from different lat, long coordinates. -> Check Journals - Its also in Status.json
  • Save a current position somewhere upon scan if its not the final one. max. 2, needs lat, long,
  • Get a list of colonial ranges for the different types of exobiology: https://canonn.science/codex/organic-scanning-challenge-primer/ might not be fully exhaustive gotta check for any that might be missing with the ingame Codex
  • Show current distance to scanned positions and colonial range of last scanned exobiology
  • Change colour of label showing current distance to the last scan position(s) (further away than colonial range = green, when not = yellow/orange)
  • Maybe when heading towards an old scan position the corresponding label showing should be yellow, or red if already yellow.
  • Stop showing the info after the 3rd and final Scan.
  • Options to omit the Info from the plugin.

Balvald added a commit that referenced this issue Nov 27, 2022
- Added the buttons for tracking the sold organic scans from journals mentioned in #4

- Moved the vista genomics price table to its own file organicinfo.py
and already created a list of clonal colonial ranges in m for #2

- Changed the journalcrawler.py so it can be effectively used in the context of being part of the edmc plugin i.e. switched to logger.info calls so the edmc log shows some info when building the soldbbiodata.json

- Needs change: journal paths are hardcoded. It'll work as long as it is in <userprofile>\Savedgames\Frontier_Developments\Elite_Dangerous/ Theres a journal file path that the user can specify in the edmc settings, gotta check how I can just get the path from it.
@Balvald Balvald self-assigned this Nov 30, 2022
@Balvald Balvald modified the milestones: v0.1.2, v0.1.3 Dec 1, 2022
Balvald added a commit that referenced this issue Dec 5, 2022
- fixed docstring for journal_entry()
- logging the whole state of the current journal_entry() to check them out.
- logging the whole status.json state so I can check to what changes I can and have to react for the CCR feature #2
@Balvald Balvald closed this as completed Dec 14, 2022
@Balvald Balvald linked a pull request Dec 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants