Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] show value of current, partial sample #29

Closed
slippycheeze opened this issue Dec 30, 2022 · 0 comments · Fixed by #33
Closed

[Feature] show value of current, partial sample #29

slippycheeze opened this issue Dec 30, 2022 · 0 comments · Fixed by #33
Assignees
@Balvald
Labels
enhancement New feature or request
Milestone
v0.2.2

Comments

@slippycheeze
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Sometimes, it is very annoying or difficult to find three samples of something. For example, bacterial colonies are sometimes nothing but a vague difference in pattern on a busy surface, or a fungoida lives up in the hills hidden from everyone.

Right now I find myself wondering "is it worth the effort to track down the third sample?"; I'd certainly put in more work for a $19M sample than a $1M sample.

Describe the solution you'd like
If I could see the value of the thing I was currently sampling that'd make it easier to prioritise ("drop this one sample, with no other growths in evidence, and take another thing") or decide to abandon a search ("I'm not getting a headache staring at this dirt for a $1M bacteria")

Describe alternatives you've considered
Right now I look up the value by hand, which is much more cumbersome. :)

Additional context
In my imagination it'd be something like this, but I'm sure there are other ways to display the information that'd work well too.

Unsold Scan Value:  158,209,100 Cr.  (plus 1/3 of 17,900,000 Cr.)
@slippycheeze slippycheeze added the enhancement New feature or request label Dec 30, 2022
@Balvald Balvald self-assigned this Jan 1, 2023
@Balvald Balvald added this to the v0.2.2 milestone Jan 2, 2023
Balvald added a commit that referenced this issue Jan 2, 2023
@Balvald
Update load.py
375ca80 
visually seperated the autom. hiding features from the "hide X" tickboxes by adding an additional line.

gave the option that hosrtens the credits down to 4 digits a more fitting name in the settings.

increased version number v0.2.2

State on dev should now be:
Implemented:
#28 , #29, #30, #31
Fixed:
#32

Regarding #28 I thought it is important enough to always be visible along either just species or full status (as species is part of full status) so no extra hiding option needed for this.

I want to do some additional testing regarding #28 before declaring this the next update.
Balvald added a commit that referenced this issue Jan 2, 2023
@Balvald
Update Readme for v0.2.2
7b6153a 
- New picture for preferences.
- Added missing option and updated renamed buttons
- Most new featues are options or slight changes to already existing features.

Now with the readme updated
I'll tag the rest of the issues as finished once I pull everything over.

closes #31 #30 #29 #28
@Balvald Balvald linked a pull request Jan 2, 2023 that will close this issue
Pull state for v0.2.2 to main #33
Merged
Balvald added a commit that referenced this issue Jan 3, 2023
@Balvald
Update load.py
c6cc40a 
visually seperated the autom. hiding features from the "hide X" tickboxes by adding an additional line.

gave the option that hosrtens the credits down to 4 digits a more fitting name in the settings.

increased version number v0.2.2

State on dev should now be:
Implemented:
#28 , #29, #30, #31
Fixed:
#32

Regarding #28 I thought it is important enough to always be visible along either just species or full status (as species is part of full status) so no extra hiding option needed for this.

I want to do some additional testing regarding #28 before declaring this the next update.
Balvald added a commit that referenced this issue Jan 3, 2023
@Balvald
Update Readme for v0.2.2
ea736eb 
- New picture for preferences.
- Added missing option and updated renamed buttons
- Most new featues are options or slight changes to already existing features.

Now with the readme updated
I'll tag the rest of the issues as finished once I pull everything over.

closes #31 #30 #29 #28
Balvald added a commit that referenced this issue Jan 8, 2023
@Balvald
fixing unintentional behaviour of #37 fix
1195d4d 
What was missing:

In "Log" scantype event did not clear the scan 2 pos distance string.
since after "Log" we only have distance 1.

didn't use the proper last_scan_plant string (have to split it because of #29 ) didn't do that before was resetting distance 1 without showing everytime before I changed this. Also forgot to clear the string variable.

Though I needed to adjust the case for when to update the distances.
Might be doing nothing since on "1/3" plugin.AST_scan_2_pos_vector[0] will always be None.
atleast now it properly checks for plugin.AST_scan_2_pos_vector.

extended line in the preferences menu.
no string or other ui element in there should be longer than line.

readme updated so that the "new" features are not really new since they've been in two prior releases. with varying ways of them working.

demoted all the logger.info calls in journalcrawler.py to logger.debug.
Balvald added a commit that referenced this issue Jan 8, 2023
@Balvald
fixing unintentional behaviour of #37 fix
fc154ae 
What was missing:

In "Log" scantype event did not clear the scan 2 pos distance string.
since after "Log" we only have distance 1.

didn't use the proper last_scan_plant string (have to split it because of #29 ) didn't do that before was resetting distance 1 without showing everytime before I changed this. Also forgot to clear the string variable.

Though I needed to adjust the case for when to update the distances.
Might be doing nothing since on "1/3" plugin.AST_scan_2_pos_vector[0] will always be None.
atleast now it properly checks for plugin.AST_scan_2_pos_vector.

extended line in the preferences menu.
no string or other ui element in there should be longer than line.

readme updated so that the "new" features are not really new since they've been in two prior releases. with varying ways of them working.

demoted all the logger.info calls in journalcrawler.py to logger.debug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Balvald Balvald

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging a pull request may close this issue.

Pull state for v0.2.2 to main Balvald/ArtemisScannerTracker
2 participants
@slippycheeze @Balvald