Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Animate player movements #242

Open
cool-RR opened this issue Nov 4, 2022 · 2 comments
Open

Feature request: Animate player movements #242

cool-RR opened this issue Nov 4, 2022 · 2 comments
Labels
enhancement New feature or request GriddlyJS An issues specifically relating to GriddlyJS

Comments

@cool-RR
Copy link
Contributor

cool-RR commented Nov 4, 2022

I just found Griddly and I'm psyched. This'll be very helpful for me, and I still need to understand how it works.

One thing I was disappointed with is that the game visualization doesn't animate the player movement, i.e. the players jump discretely from cell to cell rather than move there in a linear motion. It's weird to me that you'd take this design choice, since I would think that slick visualizations are a prime feature of Griddly. The difference between the experience of watching a game with movement animation and one without is substantial. Check out this "GridRoyale" environment and UI I designed two years ago with movement animation: https://grid-royale.herokuapp.com/

I'm guessing you may have discussed this before, but I couldn't find it on the issue tracker.

What do you think about adding this feature?

@Bam4d
Copy link
Owner

Bam4d commented Nov 5, 2022

Hi @cool-RR. As Griddly is a tool for discrete grid-world environments primarily for use in reinforcement learning, the movements are typically discrete because they happen within single time-steps.

I agree adding this linear movement would look slick, but it will not reflect what is happening in the underlying game engine itself. Many people will want to use algorithms that learn directly from the pixel representations, and in this case the linear interpolation will not reflect the underlying MDP state.

It would be possible to add these animations for visualization/demo purposes, but this will probably only be a feature in the browser itself. I think this could be added fairly easily using phaser ....

@cool-RR
Copy link
Contributor Author

cool-RR commented Nov 5, 2022

Thanks for the quick reply.

Yes, linear movements don't represent what actually happens in the game mechanics; neither do the sprites that Griddly uses nor the clever tiling logic that makes walls look great when placed next to each other.

Like these two features I mentioned, the movement animation feature I'm proposing is strictly for improving the viewing experience, and it should definitely be implemented only when visualizing for humans.

@Bam4d Bam4d added enhancement New feature or request GriddlyJS An issues specifically relating to GriddlyJS labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GriddlyJS An issues specifically relating to GriddlyJS
Projects
None yet
Development

No branches or pull requests

2 participants