…amount.

… CI, just convenient at times (nanocurrency#3407)

…_ref

Converting sever static initializations of nano::network_params to references

…ency#3398)

…nce to network_params.

* fixes regression allowing for networks to honor build and runtime selection

* clang-format

… process and remove the subsequently unused instance of nano::network_params that was instantiated statically.

…ants

…uffer to using channel::send

…ssary. Serializing this version number to/from the message_header the same as the other two version_max and version_using.

…erencing it statically.

…_buffer.

…r than on message header construction. This separates the assignment of protocol-specific information, specifically the version numbers, from the logic of creating messages.

…atically instantiated dev network params with the version available in the nano::dev namespace.

…instantiation of network parameters to test if a state block is an epoch.

…c information to determine network.

…work_constants in order to eliminate guesswork of setting these values before serializing.

…_ref

Removing static initialization of nano::network_params

…s path are no longer supported in the upgrade path. (nanocurrency#3414)

* Remove qt_system target we dont need it or use it

* cmake format sanitization

…stantiating statically.

…tiation.

… belong, rather than on network_constants.

…et rather than instantiating it statically.

…itializing statically.

… constructing it.

…dard always_log message. We don't log error messages to cerr so this was out of place.

Removing an unnecessary check for vacuuming within unit tests. This would be functionally equivalent yet potentially a performance issue. Timing the unit tests showed < 1% difference in time.

…coroutines are no longer used.

…ms initialization on to nano::work_thresholds class where they belong.

…_thresholds whre it belongs and to remove static instantiation of network_constants.

…hresholds.

…hresholds.

…ferences to nano::network_constants from within the ledger processor.

…'s redundant and removing static instantiation of network_constants.

…ssociated static instantiation of network_constants. No appreciable difference in unit test speed.

…on't directly have access to the network constants. node_rpc_config::set_request_callback is used for testing though nothing functionally requires it to be called from a unit test context. write_database_queue::contains checks that it's only called in a unit test context though this is also not functionally required. Calling the count function on several of the db tables has a performance impact though nothing about it is functionally incorrect and the caller needs to determine if the performance hit is acceptable.

…s the responsibility of determining difficulty fully on to work_thresholds rather than splitting this responsibliity with nano::block.

…oesn't need a static reference.

…olding a reference.

…ias with other instances of ledger_constants.

…nd including a referencing it within ledger_constants and network_constants instead of creating copies.

…c_constants

Remove static instantiation of network_constants

…k off of nano_dev_network. (nanocurrency#3422)

…ase build indicator (nanocurrency#3416)

… before being corrected for out-of-bounds values. Also fixed issue where the button id was assumed to be the index but it's actually a free-mapping. Changed mapped keys to be actual button index. (nanocurrency#3428)

…. Convert nano::bootstrap_connection::connections to a reference since it doesn't manage lifetime. (nanocurrency#3435)

…to be non-null on construction and is never nulled out during execution. (nanocurrency#3441)

Original commit references a leak, however, none of the clearing operations actually close the socket, they simply decrement the shared_ptr counter.
Additionally, removal operations are incorrectly implemented as they delete the shared_ptr in question and every shared_ptr following until the end of the container.

…the peering port of the node. Values are also filled from the lowest index so the lowest entries would get clobbered. Preserve these values in index 2 and 3. (nanocurrency#3445)

…#3446)

Removes usage of start_tcp callback and replace it with simple polling for an established connection.

… queried via an observer set in rep_crawler::rep_crawler.

…nnecessary.

…_fallback. Directly call send_keepalive in place of using this callback.

…anocurrency#3450)

* Force a fixed required version of clang-format

* Update github action to install clang-format 12 instead of 10

* Update GitHub actions agent OS to Ubuntu 20.04 instead of 18.04

* More verbose CI script

…nanocurrency#3459)

…anocurrency#3438)

…#3424) (nanocurrency#3429)

…nocurrency#3447)

The node_wrapper was using dev network params instead of active network
params. This caused some CLI commands (at least --wallet_create and
wallet_list) to fail.

To fix the bug, for now, I created a local copy of network_params in
node_wrapper and initialise it with active_network.

However, it would be better to have a network_param reference passed down
so that we do not have multiple copies of network_params. I created an
issue for that improvement:
nanocurrency/nano-node-internalonly#73

Prints all ledger blocks to stdout in text form

The --initialize command initialises the data folder, if it is not already
initialised. It creates a ledger file and adds the genesis block.

…etwork_params

Fix broken cli commands: wallet_create, wallet_list (issue nanocurrency#3447), diagnostics (issue  nanocurrency#3452) and other CLI  commands

The wallet_create and wallet_list CLI commands were broken. Probably many CLI commands were broken.
The problem was that inactive_node class only worked in dev network and inactive_node is used in a lot of CLI commands. In other words the CLI comamnds using inactive_node could not work in live, beta or test networks.

I fixed the diagnostics CLI command so that I could write a test script for the wallet commands.

I introduced the initialize CLI command to initialize the data folder, which was also need in order to write a test case for the wallet commands.

I introduced the CLI command debug_block_dump to print ledger blocks so that I can check that initialize commands works correctly for the different networks (live, beta, test).

* Improve the detection of non-clang-format-compliant commits/diffs

* Fix formatting

* Add .clang-format to version control; have it consistent and fixed across environments

…#3467)

Co-authored-by: theohax <theo@nano.org>

The following flags become settable from command line:
disable_ongoing_bootstrap
disable_rep_crawler
disable_request_loop

The add inital peers function reads the peers table and contacts all
the peers listed in it. It is called at startup.

To disable outgoing connections set:
--disable_rep_crawler and --disable_add_initial_peers

The unit test rpc.epoch_upgrade had a race condition.
It tries to detect the transient state where the upgrade is in progress
but it is not guaranteed that that state can be detected every time.

Fixes nanocurrency#3476