Rep crawler weight minimum #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use if guards to remove a couple of levels of nested ifs that was making the code difficult to read.
…ntries It would be nice to know if an entry is new or if an entry is changing existing data. Also print the account address of the rep involved. If modifying data, print the previous data too.
clemahieu
reviewed
Oct 27, 2021
clemahieu
previously approved these changes
Oct 27, 2021
…on PRs Introduced a new node config called 'rep_crawler_weight_minimum'. If rep_crawler_weight_minimum is less than the PR minimum weight then that becomes the minimum weight that the rep crawler tracks. Setting rep_crawler_weight_minimum to zero would track all reps.
Previously the minimum value was not part of the accepted range, which did not make much sense logically. in practice, this change should be so small that it should insignificant.
dsiganos
force-pushed
the
rep_crawler_weight_minimum
branch
from
61eb2d2
to
82f97ad
Compare
clemahieu
approved these changes
Oct 28, 2021
theohax
approved these changes
Oct 28, 2021
zhyatt
added
logging
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a feature to allow the rep crawler to track reps with weight lower than principal rep.
This is for debugging purposes and for websites that would like to track all online reps irrespective of weight.
I also introduce the framework for rep crawler log messages.
And I updated the Representative Found" to print the channel info and also to distinguish between an addition
and an update. And on update it prints the channel before and after to help us diagnose problems with reps not having
the correct IP address.
Fixes #2176