Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current release jars miss META-INF/LICENSE. #1

Closed
Baqer112 opened this issue May 4, 2023 · 0 comments
Closed

The current release jars miss META-INF/LICENSE. #1

Baqer112 opened this issue May 4, 2023 · 0 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@Baqer112
Copy link
Owner

Baqer112 commented May 4, 2023

The current release jars miss META-INF/LICENSE.
For instance, see https://repo1.maven.org/maven2/com/google/guava/guava/31.1-jre/ -> guava-31.1-jre.jar

% unzip -l guava-31.1-jre.jar  | grep META-INF
     2578  02-28-2022 16:18   META-INF/MANIFEST.MF
        0  02-28-2022 16:18   META-INF/
        0  02-28-2022 16:18   META-INF/maven/
        0  02-28-2022 16:18   META-INF/maven/com.google.guava/
        0  02-28-2022 16:18   META-INF/maven/com.google.guava/guava/
      133  02-28-2022 16:18   META-INF/maven/com.google.guava/guava/pom.properties
    10981  02-28-2022 16:06   META-INF/maven/com.google.guava/guava/pom.xml

The license requires to give a copy of the license when redistributing the software:

See https://www.apache.org/licenses/LICENSE-2.0
4.a You must give any other recipients of the Work or Derivative Works a copy of this License; and

Even though the jar file includes a link to http://www.apache.org/licenses/LICENSE-2.0.txt, the link is not a copy as the link might become inaccessible, so the recipients might fail to receive "a copy of the License".

I suggest including the license file as META-INF/LICENSE.

By the way, Google Guice does include the license (Apache-2.0) as META-INF/LICENSE: https://repo1.maven.org/maven2/com/google/inject/guice/5.1.0/

Just in case, here's the opinion of the Apache Software Foundation: https://issues.apache.org/jira/browse/LEGAL-642

Originally posted by @vlsi in google/guava#6468

@Baqer112 Baqer112 closed this as completed May 4, 2023
@Baqer112 Baqer112 reopened this May 4, 2023
@Baqer112 Baqer112 closed this as not planned Won't fix, can't repro, duplicate, stale May 5, 2023
@Baqer112 Baqer112 added the help wanted Extra attention is needed label May 5, 2023
@Baqer112 Baqer112 self-assigned this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant