chore: re-enable K8s-related unit tests (grafana#5944)

Signed-off-by: hainenber <dotronghai96@gmail.com>
BarunKGP · Dec 18, 2023 · a964cae · a964cae
1 parent fadf21f
commit a964cae
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 18 deletions.
diff --git a/component/remote/vault/vault_test.go b/component/remote/vault/vault_test.go
@@ -143,9 +143,6 @@ func Test_PollSecrets(t *testing.T) {
 }
 
 func getTestVaultServer(t *testing.T) *vaultapi.Client {
-	// TODO: this is broken with go 1.20.6
-	// waiting on https://github.com/testcontainers/testcontainers-go/issues/1359
-	t.Skip()
 	ctx := componenttest.TestContext(t)
 	l := util.TestLogger(t)
 

diff --git a/pkg/operator/build_hierarchy_test.go b/pkg/operator/build_hierarchy_test.go
@@ -27,9 +27,6 @@ import (
 // Test_buildHierarchy checks that an entire resource hierarchy can be
 // discovered.
 func Test_buildHierarchy(t *testing.T) {
-	// TODO: this is broken with go 1.20.6
-	// waiting on https://github.com/testcontainers/testcontainers-go/issues/1359
-	t.Skip()
 	var wg sync.WaitGroup
 	defer wg.Wait()
 

diff --git a/pkg/operator/hierarchy/hierarchy_test.go b/pkg/operator/hierarchy/hierarchy_test.go
@@ -21,9 +21,6 @@ import (
 // TestNotifier tests that notifier properly handles events for changed
 // objects.
 func TestNotifier(t *testing.T) {
-	// TODO: this is broken with go 1.20.6
-	// waiting on https://github.com/testcontainers/testcontainers-go/issues/1359
-	t.Skip()
 	l := log.NewNopLogger()
 
 	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute)

diff --git a/pkg/operator/kubelet_test.go b/pkg/operator/kubelet_test.go
@@ -22,9 +22,6 @@ import (
 
 // TestKubelet tests the Kubelet reconciler.
 func TestKubelet(t *testing.T) {
-	// TODO: this is broken with go 1.20.6
-	// waiting on https://github.com/testcontainers/testcontainers-go/issues/1359
-	t.Skip()
 	l := util.TestLogger(t)
 
 	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute)

diff --git a/pkg/operator/operator_test.go b/pkg/operator/operator_test.go
@@ -140,9 +140,6 @@ func ReconcileTest(ctx context.Context, t *testing.T, inFile, outFile string) {
 // NewTestCluster creates a new testing cluster. The cluster will be removed
 // when the test completes.
 func NewTestCluster(ctx context.Context, t *testing.T, l log.Logger) *k8s.Cluster {
-	// TODO: this is broken with go 1.20.6
-	// waiting on https://github.com/testcontainers/testcontainers-go/issues/1359
-	t.Skip()
 	t.Helper()
 
 	cluster, err := k8s.NewCluster(ctx, k8s.Options{})

diff --git a/pkg/util/k8s/k8s_test.go b/pkg/util/k8s/k8s_test.go
@@ -12,9 +12,6 @@ import (
 )
 
 func TestCluster(t *testing.T) {
-	// TODO: this is broken with go 1.20.6
-	// waiting on https://github.com/testcontainers/testcontainers-go/issues/1359
-	t.Skip()
 	ctx := context.Background()
 
 	cluster, err := NewCluster(ctx, Options{})