Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enable K8s-related unit tests #5944

Merged

Conversation

hainenber
Copy link
Contributor

PR Description

The commented issue has been fixed in testcontainers-go v0.25.0, which is already present in go.mod

Which issue(s) this PR fixes

N/A

Notes to the Reviewer

N/A

PR Checklist

N/A

Signed-off-by: hainenber <dotronghai96@gmail.com>
@erikbaranowski erikbaranowski self-assigned this Dec 18, 2023
Copy link
Contributor

@erikbaranowski erikbaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@erikbaranowski erikbaranowski merged commit a964cae into grafana:main Dec 18, 2023
10 checks passed
erikbaranowski added a commit that referenced this pull request Dec 18, 2023
erikbaranowski added a commit that referenced this pull request Dec 18, 2023
@erikbaranowski
Copy link
Contributor

let's reopen this and update the drone build to run the containerized tests on the PR before merge. It failed on main with how the runs differ:

https://drone.grafana.net/grafana/agent/15295
https://github.com/grafana/agent/commits/main/

BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
Signed-off-by: hainenber <dotronghai96@gmail.com>
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants