Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bStats 429 Ratelimit errors less scary looking #86

Open
Bastian opened this issue May 5, 2021 · 4 comments
Open

Make bStats 429 Ratelimit errors less scary looking #86

Bastian opened this issue May 5, 2021 · 4 comments

Comments

@Bastian
Copy link
Owner

Bastian commented May 5, 2021

Currently, a huge stack trace is logged if a 429 Ratelimit errors is encountered (and logFailedRequests is enabled).

Since 429 are expected and are nearly guaranteed to happen once after server startup the error message should be shorter and explain that it is no problem.

@isiah-lloyd
Copy link

I agree, I was adding custom chars to my plugin and got the 429 error and assumed it was something wrong with my implementation.

@ChrissW-R1

This comment was marked as off-topic.

@Bastian

This comment was marked as off-topic.

@ChrissW-R1
Copy link

Please just set logFailedRequests to false. It's a debug option that was never intended to be enabled the whole time.

Thanks. This worked for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants